Re: [PATCH v3 2/2] s390/pgtable: add missing hardware bits for puds, pmds

[Claudio Imbrenda]

On Mon, 29 Apr 2024 15:11:49 +0200
Heiko Carstens <hca@xxxxxxxxxxxxx> wrote:

> On Fri, Apr 26, 2024 at 02:04:47PM +0200, Claudio Imbrenda wrote:
> > Add the table type and ACCF validity bits to _SEGMENT_ENTRY_BITS and
> > _SEGMENT_ENTRY_HARDWARE_BITS{,_LARGE}.
> > 
> > For completeness, introduce _REGION3_ENTRY_HARDWARE_BITS_LARGE and
> > _REGION3_ENTRY_HARDWARE_BITS, containing the hardware bits used for
> > large puds and normal puds.
> > 
> > Signed-off-by: Claudio Imbrenda <imbrenda@xxxxxxxxxxxxx>
> > ---
> >  arch/s390/include/asm/pgtable.h | 8 +++++---
> >  1 file changed, 5 insertions(+), 3 deletions(-)  
> 
> ...
> > +#define _REGION3_ENTRY_HARDWARE_BITS_LARGE	0xffffffff8001073cUL
> > +#define _REGION3_ENTRY_HARDWARE_BITS		0xfffffffffffff6ffUL  
> ...
> > +#define _SEGMENT_ENTRY_BITS			0xfffffffffffffe3fUL
> > +#define _SEGMENT_ENTRY_HARDWARE_BITS		0xfffffffffffffe3cUL
> > +#define _SEGMENT_ENTRY_HARDWARE_BITS_LARGE	0xfffffffffff1073cUL  
> 
> Please resend and make sure the order (BITS, BITS_LARGE, ...) is the
> same; then Alexander can pick this up.

oops, will fix

> 
> For the definitions:
> Reviewed-by: Heiko Carstens <hca@xxxxxxxxxxxxx>