Re: [PATCH] macintosh/via-macii: Fix "BUG: sleeping function called from invalid context"

From: Geert Uytterhoeven
Date: Mon Apr 29 2024 - 10:37:47 EST


On Wed, Mar 13, 2024 at 3:55 AM Finn Thain <fthain@xxxxxxxxxxxxxx> wrote:
> The via-macii ADB driver calls request_irq() after disabling hard
> interrupts. But disabling interrupts isn't necessary here because the
> VIA shift register interrupt was masked during VIA1 initialization.
>
> Cc: Joshua Thompson <funaho@xxxxxxxxx>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Signed-off-by: Finn Thain <fthain@xxxxxxxxxxxxxx>

Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
i.e. will queue in the m68k tree for v6.10.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds