Re: [PATCH v2 5/9] selftests/landlock: Do not allocate memory in fixture data

From: Kees Cook
Date: Mon Apr 29 2024 - 11:52:58 EST


On Mon, Apr 29, 2024 at 03:09:27PM +0200, Mickaël Salaün wrote:
> Do not allocate self->dir_path in the test process because this would
> not be visible in the FIXTURE_TEARDOWN() process when relying on
> fork()/clone3() instead of vfork().
>
> This change is required for a following commit removing vfork() call to
> not break the layout3_fs.* test cases.
>
> Cc: Günther Noack <gnoack@xxxxxxxxxx>
> Cc: Kees Cook <keescook@xxxxxxxxxxxx>
> Cc: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Mickaël Salaün <mic@xxxxxxxxxxx>

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

--
Kees Cook