Re: [PATCH v2 4/4] dax/bus.c: Use the right locking mode (read vs write) in size_show

From: Dan Williams
Date: Mon Apr 29 2024 - 21:26:58 EST


Vishal Verma wrote:
> In size_show(), the dax_dev_rwsem only needs a read lock, but was
> acquiring a write lock. Change it to down_read_interruptible() so it
> doesn't unnecessarily hold a write lock.
>
> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
> Fixes: c05ae9d85b47 ("dax/bus.c: replace driver-core lock usage by a local rwsem")
> Signed-off-by: Vishal Verma <vishal.l.verma@xxxxxxxxx>
> ---
> drivers/dax/bus.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Looks good,

Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>