Re: [EXTERNAL] Re: [net-next PATCH v3 3/9] octeontx2-pf: Create representor netdev

From: Jiri Pirko
Date: Tue Apr 30 2024 - 02:57:17 EST


Mon, Apr 29, 2024 at 06:13:56PM CEST, gakula@xxxxxxxxxxx wrote:
>
>
>> -----Original Message-----
>> From: Jiri Pirko <jiri@xxxxxxxxxxx>
>> Sent: Monday, April 29, 2024 5:03 PM
>> To: Geethasowjanya Akula <gakula@xxxxxxxxxxx>
>> Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; kuba@xxxxxxxxxx;
>> davem@xxxxxxxxxxxxx; pabeni@xxxxxxxxxx; edumazet@xxxxxxxxxx; Sunil
>> Kovvuri Goutham <sgoutham@xxxxxxxxxxx>; Subbaraya Sundeep Bhatta
>> <sbhatta@xxxxxxxxxxx>; Hariprasad Kelam <hkelam@xxxxxxxxxxx>
>> Subject: [EXTERNAL] Re: [net-next PATCH v3 3/9] octeontx2-pf: Create
>> representor netdev
>>
>> Prioritize security for external emails: Confirm sender and content safety
>> before clicking links or opening attachments
>>
>> ----------------------------------------------------------------------
>> Sun, Apr 28, 2024 at 12:53:06PM CEST, gakula@xxxxxxxxxxx wrote:
>> >Adds initial devlink support to set/get the switchdev mode.
>> >Representor netdevs are created for each rvu devices when the switch
>> >mode is set to 'switchdev'. These netdevs are be used to control and
>> >configure VFs.
>> >
>> >Signed-off-by: Geetha sowjanya <gakula@xxxxxxxxxxx>
>>
>>
>> Are you still missing creating of devlink port as I requested? Why?
>Sorry I missed your comment on earlier patchset.
>Wrt adding devlink port support, our plan is to get the initial patchset reviewed and then add 'devlink port' support.

You need to do it in this patchset. Rep netdev without devlink port is
unacceptable from my perspective. Thanks!


>Will submit 'devlink port' support as a follow-up patch series.