Re: [PATCH] kunit: Cover 'assert.c' with tests

[Ivan Orlov]

On 4/29/24 22:26, Rae Moar wrote:
> On Sat, Apr 27, 2024 at 6:04 PM Ivan Orlov <ivan.orlov0322@xxxxxxxxx> wrote:
> > There are multiple assertion formatting functions in the `assert.c`
> > file, which are not covered with tests yet. Implement the KUnit test
> > for these functions.
> >
> > The test consists of 11 test cases for the following functions:
> >
> > 1) 'is_literal'
> > 2) 'is_str_literal'
> > 3) 'kunit_assert_prologue', test case for multiple assert types
> > 4) 'kunit_assert_print_msg'
> > 5) 'kunit_unary_assert_format'
> > 6) 'kunit_ptr_not_err_assert_format'
> > 7) 'kunit_binary_assert_format'
> > 8) 'kunit_binary_ptr_assert_format'
> > 9) 'kunit_binary_str_assert_format'
> > 10) 'kunit_assert_hexdump'
> > 11) 'kunit_mem_assert_format'
> >
> > The test aims at maximizing the branch coverage for the assertion
> > formatting functions. As you can see, it covers some of the static
> > helper functions as well, so we have to import the test source in the
> > `assert.c` file in order to be able to call and validate them.
> >
> > Signed-off-by: Ivan Orlov <ivan.orlov0322@xxxxxxxxx>
>
> Hello,
>
> I'll give this a full review tomorrow. But with a quick glance and
> test, this is looking good to me.
>
> Tested-by: Rae Moar <rmoar@xxxxxxxxxx>
>
> Thanks!
> -Rae

Hi Rae,

Thanks a lot for testing the patch.

Looking forward to seeing your review! :)

--
Kind regards,
Ivan Orlov