Re: [PATCH v2 1/2] dt-bindings: clock: qcom: Update SM8150 videocc bindings

[Satya Priya Kakitapalli (Temp)]

On 4/2/2024 9:35 PM, Rob Herring wrote:
> On Mon, Apr 01, 2024 at 04:44:23PM +0530, Satya Priya Kakitapalli wrote:
> > Update the clocks list for SM8150 to add both AHB and XO clocks,
> > as it needs both of them.
> I read this as you are adding 2 clocks, but it is really just 1 you are
> adding (iface).


Yes, I am adding AHB (iface) as its needed for SM8150, which is not 
present in the current bindings.


> This should have more detail on why breaking the ABI is okay here.


Sure, I'll update the commit text accordingly.


> > Fixes: 35d26e9292e2 ("dt-bindings: clock: Add YAML schemas for the QCOM VIDEOCC clock bindings")
> > Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@xxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/clock/qcom,videocc.yaml         | 17 ++++++++++++++++-
> >   1 file changed, 16 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
> > index 6999e36ace1b..68bac801adb0 100644
> > --- a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
> > +++ b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
> > @@ -75,7 +75,6 @@ allOf:
> >             enum:
> >               - qcom,sc7180-videocc
> >               - qcom,sdm845-videocc
> > -            - qcom,sm8150-videocc
> >       then:
> >         properties:
> >           clocks:
> > @@ -101,6 +100,22 @@ allOf:
> >               - const: bi_tcxo
> >               - const: bi_tcxo_ao
> >   
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          enum:
> > +            - qcom,sm8150-videocc
> > +    then:
> > +      properties:
> > +        clocks:
> > +          items:
> > +            - description: AHB
> > +            - description: Board XO source
> > +        clock-names:
> > +          items:
> > +            - const: iface
> > +            - const: bi_tcxo
> > +
> >     - if:
> >         properties:
> >           compatible:
> >
> > --
> > 2.25.1