Re: [PATCH 1/5] iio: temperature: mcp9600: set channel2 member

From: Jonathan Cameron
Date: Tue Apr 30 2024 - 08:11:14 EST


On Tue, 30 Apr 2024 14:05:31 +0200
Dimitri Fedrau <dima.fedrau@xxxxxxxxx> wrote:

> Set channel2 member of channel 0 to IIO_MOD_TEMP_OBJECT and set modified
> member to 1.
This an ABI change, so needs a strong argument + must be a fix
rather than an improvement. So why does this need to change?

Jonathan

>
> Signed-off-by: Dimitri Fedrau <dima.fedrau@xxxxxxxxx>
> ---
> drivers/iio/temperature/mcp9600.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/iio/temperature/mcp9600.c b/drivers/iio/temperature/mcp9600.c
> index 7a3eef5d5e75..e277edb4ae4b 100644
> --- a/drivers/iio/temperature/mcp9600.c
> +++ b/drivers/iio/temperature/mcp9600.c
> @@ -26,6 +26,8 @@ static const struct iio_chan_spec mcp9600_channels[] = {
> {
> .type = IIO_TEMP,
> .address = MCP9600_HOT_JUNCTION,
> + .channel2 = IIO_MOD_TEMP_OBJECT,
> + .modified = 1,
> .info_mask_separate =
> BIT(IIO_CHAN_INFO_RAW) | BIT(IIO_CHAN_INFO_SCALE),
> },