Re: [PATCH 11/15] i2c: jz4780: use 'time_left' variable with wait_for_completion_timeout()

From: Philippe Mathieu-Daudé
Date: Tue Apr 30 2024 - 08:43:51 EST


On 27/4/24 22:36, Wolfram Sang wrote:
There is a confusing pattern in the kernel to use a variable named 'timeout' to
store the result of wait_for_completion_timeout() causing patterns like:

timeout = wait_for_completion_timeout(...)
if (!timeout) return -ETIMEDOUT;

with all kinds of permutations. Use 'time_left' as a variable to make the code
self explaining.

Fix to the proper variable type 'unsigned long' while here.

Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
---
drivers/i2c/busses/i2c-jz4780.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)

Reviewed-by: Philippe Mathieu-Daudé <philmd@xxxxxxxxxx>