Re: [PATCH 08/17] net: lan966x: remove debugfs directory in probe() error path

From: Andrew Lunn
Date: Tue Apr 30 2024 - 09:58:16 EST


On Tue, Apr 30, 2024 at 10:37:17AM +0200, Herve Codina wrote:
> A debugfs directory entry is create early during probe(). This entry is
> not removed on error path leading to some "already present" issues in
> case of EPROBE_DEFER.
>
> Create this entry later in the probe() code to avoid the need to change
> many 'return' in 'goto' and add the removal in the already present error
> path.
>
> Fixes: 942814840127 ("net: lan966x: Add VCAP debugFS support")
> Cc: <stable@xxxxxxxxxxxxxxx>
> Signed-off-by: Herve Codina <herve.codina@xxxxxxxxxxx>

I know you plan to split this patchset up and submit via different
subsystems. When you do, please post this for net, not net-next, since
it is a fix.

Andrew