[PATCH 6/9] iommu/amd: Convert PPR Log pointer to use the struct amd_iommu_mem

From: Suravee Suthikulpanit
Date: Tue Apr 30 2024 - 11:26:17 EST


And specify the memory to be 4K-aligned when running in SNP host,

Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
---
drivers/iommu/amd/amd_iommu_types.h | 2 +-
drivers/iommu/amd/init.c | 2 +-
drivers/iommu/amd/ppr.c | 22 ++++++++++++++--------
3 files changed, 16 insertions(+), 10 deletions(-)

diff --git a/drivers/iommu/amd/amd_iommu_types.h b/drivers/iommu/amd/amd_iommu_types.h
index af4e9ca6414e..8ced34cac1db 100644
--- a/drivers/iommu/amd/amd_iommu_types.h
+++ b/drivers/iommu/amd/amd_iommu_types.h
@@ -744,7 +744,7 @@ struct amd_iommu {
unsigned char evt_irq_name[16];

/* Base of the PPR log, if present */
- u8 *ppr_log;
+ struct amd_iommu_mem ppr_log_mem;

/* Name for PPR log interrupt */
unsigned char ppr_irq_name[16];
diff --git a/drivers/iommu/amd/init.c b/drivers/iommu/amd/init.c
index 5242a9a16946..b62d4c806155 100644
--- a/drivers/iommu/amd/init.c
+++ b/drivers/iommu/amd/init.c
@@ -3848,7 +3848,7 @@ int amd_iommu_snp_disable(void)
if (ret)
return ret;

- ret = iommu_make_shared(iommu->ppr_log, PPR_LOG_SIZE);
+ ret = iommu_make_shared(iommu->ppr_log_mem.buf, PPR_LOG_SIZE);
if (ret)
return ret;

diff --git a/drivers/iommu/amd/ppr.c b/drivers/iommu/amd/ppr.c
index 091423bb8aac..13983b4bf47b 100644
--- a/drivers/iommu/amd/ppr.c
+++ b/drivers/iommu/amd/ppr.c
@@ -19,21 +19,27 @@

int __init amd_iommu_alloc_ppr_log(struct amd_iommu *iommu)
{
- iommu->ppr_log = iommu_alloc_4k_pages(iommu, GFP_KERNEL | __GFP_ZERO,
- PPR_LOG_SIZE);
- return iommu->ppr_log ? 0 : -ENOMEM;
+ struct amd_iommu_mem *mem = &iommu->ppr_log_mem;
+
+ mem->modes = ALLOC_MODE_4K;
+ mem->order = get_order(PPR_LOG_SIZE);
+ mem->buf = amd_iommu_get_zeroed_mem(GFP_KERNEL, mem);
+ if (!mem->buf)
+ return -ENOMEM;
+ return 0;
}

void amd_iommu_enable_ppr_log(struct amd_iommu *iommu)
{
u64 entry;

- if (iommu->ppr_log == NULL)
+ if (iommu->ppr_log_mem.buf == NULL)
return;

iommu_feature_enable(iommu, CONTROL_PPR_EN);

- entry = iommu_virt_to_phys(iommu->ppr_log) | PPR_LOG_SIZE_512;
+ entry = amd_iommu_mem_to_phys(&iommu->ppr_log_mem);
+ entry |= PPR_LOG_SIZE_512;

memcpy_toio(iommu->mmio_base + MMIO_PPR_LOG_OFFSET,
&entry, sizeof(entry));
@@ -48,7 +54,7 @@ void amd_iommu_enable_ppr_log(struct amd_iommu *iommu)

void __init amd_iommu_free_ppr_log(struct amd_iommu *iommu)
{
- iommu_free_pages(iommu->ppr_log, get_order(PPR_LOG_SIZE));
+ amd_iommu_free_mem(&iommu->ppr_log_mem);
}

/*
@@ -163,7 +169,7 @@ void amd_iommu_poll_ppr_log(struct amd_iommu *iommu)
{
u32 head, tail;

- if (iommu->ppr_log == NULL)
+ if (iommu->ppr_log_mem.buf == NULL)
return;

head = readl(iommu->mmio_base + MMIO_PPR_HEAD_OFFSET);
@@ -174,7 +180,7 @@ void amd_iommu_poll_ppr_log(struct amd_iommu *iommu)
u64 entry[2];
int i;

- raw = (u64 *)(iommu->ppr_log + head);
+ raw = (u64 *)((u8 *)iommu->ppr_log_mem.buf) + head;

/*
* Hardware bug: Interrupt may arrive before the entry is
--
2.34.1