Re: [PATCH v3 00/12] mm/swap: clean up and optimize swap cache index

From: Kairui Song
Date: Tue Apr 30 2024 - 11:29:20 EST


On Tue, Apr 30, 2024 at 10:47 AM Huang, Ying <ying.huang@xxxxxxxxx> wrote:
>
> Kairui Song <ryncsn@xxxxxxxxx> writes:
>
> > From: Kairui Song <kasong@xxxxxxxxxxx>
> >
> > This is based on latest mm-unstable. Patch 1/12 might not be needed if
> > f2fs converted .readahead to use folio, I included it for easier test
> > and review.
> >
> > Currently we use one swap_address_space for every 64M chunk to reduce lock
> > contention, this is like having a set of smaller swap files inside one
> > big swap file.
>
> I would rather to say,
>
> "
> this is like having a set of smaller files inside a swap device.
> "
>
> To avoid possible confusing in this series. I suggest to avoid to say
> "swap file". Instead, we can use "swap device".

Good suggestion, will update this part.


> [snip]
>
> --
> Best Regards,
> Huang, Ying