Re: [PATCH v2 0/3] Add support for Sensirion SDP500

From: Andy Shevchenko
Date: Tue Apr 30 2024 - 11:39:40 EST


On Tue, Apr 30, 2024 at 05:27:17PM +0200, Petar Stoykov wrote:
> From c4437fd0ea296c4c964b1fb924144ae24a2ce443 Mon Sep 17 00:00:00 2001
> From: Petar Stoykov <pd.pstoykov@xxxxxxxxx>
> Date: Mon, 29 Apr 2024 16:41:30 +0200
> Subject: [PATCH 0/3] Add support for Sensirion SDP500
>
> This patch series

It's not. I mean from the email chaining perspective. Have you forgotten
to add --thread to git format-patch?

Also, what is that in above?

> introduces support for Sensirion SDP500 in the IIO
> subsystem. The series is split into three patches:
>
> 1. The first patch adds the device tree bindings.
> 2. The second patch implements the device driver.
> 3. The third patch updates the MAINTAINERS file.
>
> The driver is relatively simple. It provides a way to read the measured
> differential pressure directly in Pa, as the device has a fixed scale
> factor of 1/60. When an applications wants to read the pressure value,
> 3 bytes are read from the device, 2 are data and 1 is CRC8. If the crc
> check passes, the calculated pressure value is returned in Pa units.
>
> The initialization of the device just starts the measurement process.
>
> We have been using this device and driver in a product development for
> almost a year now. There the pressure is read every 25ms and is used in a
> control loop. We have not even seen crc errors. We are using the
> "linux-imx" repository and not the mainline one but I see no risky kernel
> functions in use so it should be fine here too.
>
> All feedback is appreciated! Thank you for taking the time to review this.

--
With Best Regards,
Andy Shevchenko