Re: [v1,3/3] drm/panel: ili9341: Use predefined error codes

From: Sui Jingfeng
Date: Tue Apr 30 2024 - 13:01:06 EST



On 2024/4/25 22:26, Andy Shevchenko wrote:
In one case the -1 is returned which is quite confusing code for
the wrong device ID, in another the ret is returning instead of
plain 0 that also confusing as readed may ask the possible meaning
of positive codes, which are never the case there. Convert both
to use explicit predefined error codes to make it clear what's going
on there.

Fixes: 5a04227326b0 ("drm/panel: Add ilitek ili9341 panel driver")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Reviewed-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx>


Reviewed-by: Sui Jingfeng <sui.jingfeng@xxxxxxxxx>


--
Best regards,
Sui