Re: [PATCH] yamllint: Drop excluding quoted values with ',' from checks

From: Conor Dooley
Date: Tue Apr 30 2024 - 13:42:38 EST


On Fri, Apr 26, 2024 at 02:54:37PM -0500, Rob Herring (Arm) wrote:
> From: Rob Herring <robh@xxxxxxxxxx>
>
> Strings with commas were excluded from checks because yamllint had false
> positives for flow style maps and sequences which need quotes when
> values contain commas. This issue has been fixed as of the 1.34 release,
> so drop the work-around.

Hmm, is this a bit aggressive of an upgrade? I only checked Debian since
it is what this machine uses, and it only seems to be shipping 1.33 in
testing & unstable.

>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>
> ---
> Documentation/devicetree/bindings/.yamllint | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/.yamllint b/Documentation/devicetree/bindings/.yamllint
> index 358c88813937..fadbc6ad3c76 100644
> --- a/Documentation/devicetree/bindings/.yamllint
> +++ b/Documentation/devicetree/bindings/.yamllint
> @@ -7,7 +7,7 @@ rules:
> quoted-strings:
> required: only-when-needed
> extra-allowed:
> - - '[$^,[]'
> + - '[$^[]'
> - '^/$'
> line-length:
> # 80 chars should be enough, but don't fail if a line is longer
> --
> 2.43.0
>

Attachment: signature.asc
Description: PGP signature