Re: [PATCH] mptcp: subflow.c: fix typo
From: Simon Horman
Date: Tue Apr 30 2024 - 14:01:12 EST
On Tue, Apr 30, 2024 at 06:50:33AM +0800, Shi-Sheng Yang wrote:
> Replace 'greceful' with 'graceful'.
>
> Signed-off-by: Shi-Sheng Yang <james1qaz2wsx12qw@xxxxxxxxx>
Hi Shi-Sheng Yang,
Elsewhere in the same file 'earlier' is mispelt as 'eariler'.
Could you consider fixing that too?
Better still, could you consider running codespell over
net/mptcp/ and fixing (the non false-positives) that it flags?
If you do repost then I think an appropriate prefix
would be 'mctp: ' rather than 'mctp: subflow.c ',
as this follows the pattern in git history.
And I think the target tree should be net-next.
That is, the patch should be based on net-next and
it should be designated in the subject.
e.g. Subject: [PATCH v2 net-next] mptcp: fix typos in comments
Lastly, please keep in mind that 24h should elapse
before posting a new version.
Link: https://docs.kernel.org/process/maintainer-netdev.html
..