RE: [PATCH v4 1/2] acpi/ghes: Process CXL Component Events

From: Luck, Tony
Date: Tue Apr 30 2024 - 15:34:12 EST


>> What's the lifetime of that record?
>>
>
> The lifetime is contained to the cxl_cper_post_envent() which does not
> block. The kfifo_put() copies the data to a cxl specific record to be
> used by the CXL thread for processing.
>
>>
>> Can it be re-used/overwritten
>> before that other kernel thread gets around to looking at it?
>
> Yes because the CXL kernel thread has its own copy in the kfifo.

Ira,

Tracking down the call chain, doubly safe. You first copy that record to
a local variable in cxl_cper_post_event() and then kfifo_put() will copy
that copy into another place for processing.

That was my only concern.

Reviewed-by: Tony Luck <tony.luck@xxxxxxxxx>

-Tony