sd.c

Liakakis Kostas (kostas@skiathos.physics.auth.gr)
Tue, 4 Jul 1995 12:04:55 +0300 (EET DST)


In patch-1.3.5 there where some #include clauses added into sd.c, arround
line 1335 (line number in the resulting file after patching):

#ifdef MODULE
#include <linux/module.h>
#include <linux/version.h>

....

Well, with these two there, especialy the module.h, make modules with
modversion feature enable will make the compile fail, with undefined
functions (that are defined in ksyms.ver). If moved to the top, before
any other include files, within an #ifdef MODULE/#endif it will go on
without error.

I guess this is the place they ought to be, judging from their place in
the other modules that are lying arround the kernel tree.

-Kostas

PS. Could the kerneld patch of Bjorn & Jacques be incorparated in the 1.3
tree? It seems pretty stable and will make patching easier (got many
rejects while patching 1.3.3 to 1.3.6). People who don't wish to use
kerneld have the config option to throw it out.

PS2. Could somebody put a proper dependency rule for making modules?
Every time I "make modules" everything gets compiled again (exept the fs
perhaps? I dont recall) which is a pain since I might only be tweaking
something in the scsi directory. Finaly it would be nice to be able to cd
drivers/scsi; make modules and work.