Re: Linux-1.3.66 - scsi.c breaks

James MacKinnon (jmack@phys.ualberta.ca)
Sun, 18 Feb 1996 11:10:30 -0700 (MST)


--
James S. MacKinnon           Office: P-139 Avahd-Bhatia Physics Lab
Department of Physics        Voice : (403) 492-8226
University of Alberta        email : Jim.MacKinnon@Phys.UAlberta.CA
Edmonton, Canada T6G 2N5
        WWW:   http://www.phys.ualberta.ca/~jmack/jmack.html   

Hi Linus,

A change to scsi.c in 1.3.66 (perhaps in 1.3.65) broke the scsi scan pass, generating the following on boot (logging to /usr/adm/messages got screwed up as well in the process). Things were ok in 1.3.64.

This is on a P586.

Hard media disks get marked as unknown type 31, and the MULTI-LUN pass goes through all phases on each disk target.

I do have a NEC CDROM drive that is multi-lun, but the hard disks were passed through all LUNS as well.

Later on in the boot e2fsck complained about the hard drives, but didn't fix. On the next boot they were marked dirty, and forced into a clean state.

The change in scsi.c that created this problem was:

/devel/src>diff -u linux-1.3.64/drivers/scsi/scsi.c linux-1.3.66/drivers/scsi/scsi.c-1.3.66 --- linux-1.3.64/drivers/scsi/scsi.c Tue Feb 6 23:55:39 1996 +++ linux-1.3.66/drivers/scsi/scsi.c-1.3.66 Sun Feb 18 10:21:29 1996 @@ -563,7 +563,8 @@ (status_byte (SCpnt->result) & CHECK_CONDITION)) && ((SCpnt->sense_buffer[0] & 0x70) >> 4) == 7) { if (((SCpnt->sense_buffer[2] & 0xf) != NOT_READY) && - ((SCpnt->sense_buffer[2] & 0xf) != UNIT_ATTENTION)) + ((SCpnt->sense_buffer[2] & 0xf) != UNIT_ATTENTION) && + ((SCpnt->sense_buffer[2] & 0xf) != ILLEGAL_REQUEST)) return 1; } else

(Don't know why the addition of ILLEGAL_REQUEST to the test mask was breaking it).

Reverting back to the 1.3.64 version of scsi.c fixes it all up properly, and also allows proper logging to /usr/adm/messages:

Here are the log bits for the broken scsi.c in 1.3.66 (pine might wrap these lines):

Feb 18 09:48:11 laddie syslogd: restart Feb 18 09:48:11 laddie kernel: Kernel logging (proc) started. Feb 18 09:48:11 laddie kernel: own type 31 Feb 18 09:48:11 laddie kernel: Vendor: FUJITSU Model: Rev: 6234 Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Vendor: NRC Model: MBR-7.4 Rev: 101 Feb 18 09:48:11 laddie kernel: Type: CD-ROM ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi CD-ROM sr0 at scsi0, channel 0, id 1, lun 0 Feb 18 09:48:11 laddie kernel: Vendor: NRC Model: MBR-7.4 Rev: 101 Feb 18 09:48:11 laddie kernel: Type: CD-ROM ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi CD-ROM sr1 at scsi0, channel 0, id 1, lun 1 Feb 18 09:48:11 laddie kernel: Vendor: NRC Model: MBR-7.4 Rev: 101 Feb 18 09:48:11 laddie kernel: Type: CD-ROM ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi CD-ROM sr2 at scsi0, channel 0, id 1, lun 2 Feb 18 09:48:11 laddie kernel: Vendor: NRC Model: MBR-7.4 Rev: 101 Feb 18 09:48:11 laddie kernel: Type: CD-ROM ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi CD-ROM sr3 at scsi0, channel 0, id 1, lun 3 Feb 18 09:48:11 laddie kernel: Vendor: NRC Model: MBR-7.4 Rev: 101 Feb 18 09:48:11 laddie kernel: Type: CD-ROM ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi CD-ROM sr4 at scsi0, channel 0, id 1, lun 4 Feb 18 09:48:11 laddie kernel: Vendor: NRC Model: MBR-7.4 Rev: 101 Feb 18 09:48:11 laddie kernel: Type: CD-ROM ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi CD-ROM sr5 at scsi0, channel 0, id 1, lun 5 Feb 18 09:48:11 laddie kernel: Vendor: NRC Model: MBR-7.4 Rev: 101 Feb 18 09:48:11 laddie kernel: Type: CD-ROM ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi CD-ROM sr6 at scsi0, channel 0, id 1, lun 6 Feb 18 09:48:11 laddie kernel: scsi: unknown type 31 Feb 18 09:48:11 laddie kernel: Vendor: NRC Model: MBR-7.4 Rev: 101 Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi generic sgp at scsi0, channel 0, id 1, lun 7 Feb 18 09:48:11 laddie kernel: Vendor: QUANTUM Model: LIGHTNING 730S Rev: 241E Feb 18 09:48:11 laddie kernel: Type: Direct-Access ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi disk sdb at scsi0, channel 0, id 2, lun 0 Feb 18 09:48:11 laddie kernel: scsi: unknown type 31 Feb 18 09:48:11 laddie kernel: Vendor: QUANTUM Model: LIGHTNING 730S Rev: 241E Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi generic sgr at scsi0, channel 0, id 2, lun 1 Feb 18 09:48:11 laddie kernel: scsi: unknown type 31 Feb 18 09:48:11 laddie kernel: Vendor: QUANTUM Model: LIGHTNING 730S Rev: 241E Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi generic sgs at scsi0, channel 0, id 2, lun 2 Feb 18 09:48:11 laddie kernel: scsi: unknown type 31 Feb 18 09:48:11 laddie kernel: Vendor: QUANTUM Model: LIGHTNING 730S Rev: 241E Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi generic sgt at scsi0, channel 0, id 2, lun 3 Feb 18 09:48:11 laddie kernel: scsi: unknown type 31 Feb 18 09:48:11 laddie kernel: Vendor: QUANTUM Model: LIGHTNING 730S Rev: 241E Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi generic sgu at scsi0, channel 0, id 2, lun 4 Feb 18 09:48:11 laddie kernel: scsi: unknown type 31 Feb 18 09:48:11 laddie kernel: Vendor: QUANTUM Model: LIGHTNING 730S Rev: 241E Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: scsi: unknown type 31 Feb 18 09:48:11 laddie kernel: Vendor: QUANTUM Model: LIGHTNING 730S Rev: 241E Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi generic sgv at scsi0, channel 0, id 2, lun 5 Feb 18 09:48:11 laddie kernel: scsi: unknown type 31 Feb 18 09:48:11 laddie kernel: Vendor: QUANTUM Model: LIGHTNING 730S Rev: 241E Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi generic sgw at scsi0, channel 0, id 2, lun 6 Feb 18 09:48:11 laddie kernel: scsi: unknown type 31 Feb 18 09:48:11 laddie kernel: Vendor: QUANTUM Model: LIGHTNING 730S Rev: 241E Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi generic sgx at scsi0, channel 0, id 2, lun 7 Feb 18 09:48:11 laddie kernel: Vendor: HP Model: C2520A Rev: 3503 Feb 18 09:48:11 laddie kernel: Type: Processor ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi generic sgy at scsi0, channel 0, id 5, lun 0 Feb 18 09:48:11 laddie kernel: scsi: unknown type 31 Feb 18 09:48:11 laddie kernel: Vendor: HP Model: C2520A Rev: 3503 Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi generic sgz at scsi0, channel 0, id 5, lun 1 Feb 18 09:48:11 laddie kernel: scsi: unknown type 31 Feb 18 09:48:11 laddie kernel: Vendor: HP Model: C2520A Rev: 3503 Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi generic sg{ at scsi0, channel 0, id 5, lun 2 Feb 18 09:48:11 laddie kernel: scsi: unknown type 31 Feb 18 09:48:11 laddie kernel: Vendor: HP Model: C2520A Rev: 3503 Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi generic sg| at scsi0, channel 0, id 5, lun 3 Feb 18 09:48:11 laddie kernel: scsi: unknown type 31 Feb 18 09:48:11 laddie kernel: Vendor: HP Model: C2520A Rev: 3503 Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi generic sg} at scsi0, channel 0, id 5, lun 4 Feb 18 09:48:11 laddie kernel: scsi: unknown type 31 Feb 18 09:48:11 laddie kernel: Vendor: HP Model: C2520A Rev: 3503 Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi generic sg~ at scsi0, channel 0, id 5, lun 5 Feb 18 09:48:11 laddie kernel: scsi: unknown type 31 Feb 18 09:48:11 laddie kernel: Vendor: HP Model: C2520A Rev: 3503 Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi generic sg^? at scsi0, channel 0, id 5, lun 6 Feb 18 09:48:11 laddie kernel: scsi: unknown type 31 Feb 18 09:48:11 laddie kernel: Vendor: HP Model: C2520A Rev: 3503 Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi generic sg Feb 18 09:48:11 laddie kernel: Vendor: IOMEGA Model: ZIP 100 Rev: R.41 Feb 18 09:48:11 laddie kernel: Type: Direct-Access ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi disk sdc at scsi0, channel 0, id 6, lun 0 Feb 18 09:48:11 laddie kernel: scsi: unknown type 31 Feb 18 09:48:11 laddie kernel: Vendor: IOMEGA Model: ZIP 100 Rev: R.41 Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi generic sg^B at scsi0, channel 0, id 6, lun 1 Feb 18 09:48:11 laddie kernel: scsi: unknown type 31 Feb 18 09:48:11 laddie kernel: Vendor: IOMEGA Model: ZIP 100 Rev: R.41 Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi generic sg^C at scsi0, channel 0, id 6, lun 2 Feb 18 09:48:11 laddie kernel: scsi: unknown type 31 Feb 18 09:48:11 laddie kernel: Vendor: IOMEGA Model: ZIP 100 Rev: R.41 Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi generic sg^D at scsi0, channel 0, id 6, lun 3 Feb 18 09:48:11 laddie kernel: scsi: unknown type 31 Feb 18 09:48:11 laddie kernel: Vendor: IOMEGA Model: ZIP 100 Rev: R.41 Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi generic sg^E at scsi0, channel 0, id 6, lun 4 Feb 18 09:48:11 laddie kernel: scsi: unknown type 31 Feb 18 09:48:11 laddie kernel: Vendor: IOMEGA Model: ZIP 100 Rev: R.41 Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi generic sg^F at scsi0, channel 0, id 6, lun 5 Feb 18 09:48:11 laddie kernel: scsi: unknown type 31 Feb 18 09:48:11 laddie kernel: Vendor: IOMEGA Model: ZIP 100 Rev: R.41 Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi generic sg^G at scsi0, channel 0, id 6, lun 6 Feb 18 09:48:11 laddie kernel: scsi: unknown type 31 Feb 18 09:48:11 laddie kernel: Vendor: IOMEGA Model: ZIP 100 Rev: R.41 Feb 18 09:48:11 laddie kernel: Type: Unknown ANSI SCSI revision: 02 Feb 18 09:48:11 laddie kernel: Detected scsi generic sg^H at scsi0, channel 0, id 6, lun 7 Feb 18 09:48:11 laddie kernel: scsi : detected 7 SCSI cdroms 3 SCSI disks total.

After the fix on scsi.c (reverting back to the 1.3.64 version), the scsi scan and log proceed normally:

Feb 18 10:25:32 laddie syslogd: restart Feb 18 10:25:32 laddie kernel: Kernel logging (proc) started. Feb 18 10:25:32 laddie kernel: Console: 16 point font, 400 scans ...[snipped out] Feb 18 10:25:32 laddie kernel: aic7xxx: Downloading sequencer code...done. Feb 18 10:25:32 laddie kernel: scsi0 : Adaptec AHA274x/284x/294x (EISA/VLB/PCI-Fast SCSI) 2.22/2.2/2.8 Feb 18 10:25:32 laddie kernel: scsi : 1 host. Feb 18 10:25:32 laddie kernel: aic7xxx: Scanning channel A for devices. Feb 18 10:25:32 laddie kernel: aic7xxx: Target 0, channel A, now synchronous at 10.0MHz, offset(0xf). Feb 18 10:25:32 laddie kernel: Vendor: FUJITSU Model: M1606S-512 Rev: 6234 Feb 18 10:25:32 laddie kernel: Type: Direct-Access ANSI SCSI revision: 02 Feb 18 10:25:32 laddie kernel: Detected scsi disk sda at scsi0, channel 0, id 0, lun 0 Feb 18 10:25:32 laddie kernel: Vendor: NRC Model: MBR-7.4 Rev: 101 Feb 18 10:25:32 laddie kernel: Type: CD-ROM ANSI SCSI revision: 02 Feb 18 10:25:32 laddie kernel: Detected scsi CD-ROM sr0 at scsi0, channel 0, id 1, lun 0 Feb 18 10:25:32 laddie kernel: Vendor: NRC Model: MBR-7.4 Rev: 101 Feb 18 10:25:32 laddie kernel: Type: CD-ROM ANSI SCSI revision: 02 Feb 18 10:25:32 laddie kernel: Detected scsi CD-ROM sr1 at scsi0, channel 0, id 1, lun 1 Feb 18 10:25:32 laddie kernel: Vendor: NRC Model: MBR-7.4 Rev: 101 Feb 18 10:25:32 laddie kernel: Type: CD-ROM ANSI SCSI revision: 02 Feb 18 10:25:32 laddie kernel: Detected scsi CD-ROM sr2 at scsi0, channel 0, id 1, lun 2 Feb 18 10:25:32 laddie kernel: Vendor: NRC Model: MBR-7.4 Rev: 101 Feb 18 10:25:32 laddie kernel: Type: CD-ROM ANSI SCSI revision: 02 Feb 18 10:25:32 laddie kernel: Detected scsi CD-ROM sr3 at scsi0, channel 0, id 1, lun 3 Feb 18 10:25:32 laddie kernel: Vendor: NRC Model: MBR-7.4 Rev: 101 Feb 18 10:25:32 laddie kernel: Type: CD-ROM ANSI SCSI revision: 02 Feb 18 10:25:32 laddie kernel: Detected scsi CD-ROM sr4 at scsi0, channel 0, id 1, lun 4 Feb 18 10:25:32 laddie kernel: Vendor: NRC Model: MBR-7.4 Rev: 101 Feb 18 10:25:32 laddie kernel: Type: CD-ROM ANSI SCSI revision: 02 Feb 18 10:25:32 laddie kernel: Detected scsi CD-ROM sr5 at scsi0, channel 0, id 1, lun 5 Feb 18 10:25:32 laddie kernel: Vendor: NRC Model: MBR-7.4 Rev: 101 Feb 18 10:25:32 laddie kernel: Type: CD-ROM ANSI SCSI revision: 02 Feb 18 10:25:32 laddie kernel: Detected scsi CD-ROM sr6 at scsi0, channel 0, id 1, lun 6 Feb 18 10:25:32 laddie kernel: Vendor: QUANTUM Model: LIGHTNING 730S Rev: 241E Feb 18 10:25:32 laddie kernel: Type: Direct-Access ANSI SCSI revision: 02 Feb 18 10:25:32 laddie kernel: Detected scsi disk sdb at scsi0, channel 0, id 2, lun 0 Feb 18 10:25:32 laddie kernel: Vendor: HP Model: C2520A Rev: 3503 Feb 18 10:25:32 laddie kernel: Type: Processor ANSI SCSI revision: 02 Feb 18 10:25:32 laddie kernel: Detected scsi generic sgj at scsi0, channel 0, id 5, lun 0 Feb 18 10:25:32 laddie kernel: Vendor: IOMEGA Model: ZIP 100 Rev: R.41 Feb 18 10:25:32 laddie kernel: Type: Direct-Access ANSI SCSI revision: 02 Feb 18 10:25:32 laddie kernel: Detected scsi disk sdc at scsi0, channel 0, id 6, lun 0 Feb 18 10:25:32 laddie kernel: scsi : detected 7 SCSI cdroms 3 SCSI disks total.

Aside form that 1.3.66 seems stable :-)