Re: 1.3.80 setup.S change prevents booting.

Hans Lermen (lermen@elserv.ffm.fgan.de)
Tue, 2 Apr 1996 01:59:43 +0200 (MET DST)


On Sat, 30 Mar 1996, Alan Cox wrote:

> > +#ifdef SAFE_RESET_DISK_CONTROLLER
> > ! Reset the disk controller.
> > mov ax,#0x0000
> > mov dl,#0x80
> > int 0x13
> > +#endif
>
> This code serves no purpose except breaking with quite a few PC's. It seems
> it belongs in the disabled state for good
>
> Alan
>

Yes, I also wondered about that piece of code. However, this is what
Linus wrote in a reply to an other posting, ... and my coments to that:

> On Fri, 29 Mar 1996, Linus Torvalds wrote:
> >
> > It does indeed fix a latency problem, but only on alpha machines (which
> > called that routine with interrupts disabled for simpler assembly code).
> > I changed the x86 asm sources to do it that way too (see the setup.S part
> > of the 80-patch)
> >
> > Linus
> >
>
> Ok, I noticed the changes to setup.S:
>
[ ... setup.S patch deleted ]
> [ no other changes in setup.S of 1.3.80 ]
>
> However, I thought they were intended to cancel any pending IO on the
> disk subsystem _before_ booting the kernel.
> How does it effect the latency problem _in_ the kernel ?
> Are you suspecting IRQs from the pre-boot-phase to lock the interrupt
> controler ?
> ( ... just to understand what is happening )

Got no answer till now.
Linus please, what is the reason for the disk reset ?

Hans
<lermen@elserv.ffm.fgan.de>