Re: pre2.0.13 oops

Sheldon E. Newhouse (sen@math.msu.edu)
Thu, 6 Jun 1996 19:26:35 -0400


This fixed it for me.
Thanks
-sen

Theodore Y. Ts'o writes:
> Date: Thu, 6 Jun 1996 14:09:58 -0400
> From: "Sheldon E. Newhouse" <sen@math.msu.edu>
>
> I was running along merrily with pre2.0.11. I just compiled pre2.0.13
> and it seems to really screw up rlogin and telnet on my P5-90.
>
> rlogin doesn't work at all and telnet gives weird echos back.
>
> This is my fault. I didn't sufficiently test the pty packet fixes, and
> cleared the pty packet mode in the hangup code, which was a mistake.
> The problem is rlogin and telnet both call vhangup() which clears the
> packet mode when they're not expecting it. The following patch should
> fix things.
>
> - Ted
>
> ===================================================================
> RCS file: drivers/char/RCS/tty_io.c,v
> retrieving revision 1.1
> diff -u -r1.1 drivers/char/tty_io.c
> --- drivers/char/tty_io.c 1996/06/06 21:18:29 1.1
> +++ drivers/char/tty_io.c 1996/06/06 21:18:53
> @@ -431,9 +431,6 @@
> tty->session = 0;
> tty->pgrp = -1;
> tty->ctrl_status = 0;
> - tty->packet = 0;
> - if (tty->link)
> - tty->link->packet = 0;
> if (tty->driver.flags & TTY_DRIVER_RESET_TERMIOS)
> *tty->termios = tty->driver.init_termios;
> if (tty->driver.hangup)
>