Cosmetics - improper registration of resources (floppy.c, serial.c)

Harald Anlauf (anlauf@crunch.ikp.physik.th-darmstadt.de)
Fri, 14 Jun 1996 10:37:05 +0200


Hi,

this is only a minor cosmetic issue, but drivers/block/floppy.c and
drivers/char/serial.c do not properly register the used resources (IRQ's).
The serial driver only registers irq 4 (com1) but not irq 3 (com2);
the floppy driver should register irq 6. Maybe this can be fixed in 2.0.x.

Example:

/proc/interrupts:
0: 478505 timer
1: 4669 keyboard
2: 0 cascade
4: 30015 + serial
11: 11096 aha1740
13: 0 math error
15: 0 + ide1

/proc/stat:
[...]
intr 863945 480156 4705 0 337352 30625 0 2 0 0 0 0 11105 0 0 0 0
[...] ^^^^^^ ^- Floppy driver (irq 6)
^^^^^^- this is irq 3 (Modem @ com2)

/proc/ioports is o.k., everything is properly registered:
[...]
02f8-02ff : serial(auto)
[...]
03f0-03f5 : floppy
03f7-03f7 : floppy DIR
03f8-03ff : serial(auto)
[...]

My .config (excerpt):
CONFIG_BLK_DEV_FD=y
CONFIG_SERIAL=y

Boot messages:
[...]
Linux version 2.0.0 (root@linux) (gcc version 2.7.2.f.1) #50 Mon Jun 10 20:24:30 MET DST 1996
Serial driver version 4.13 with no serial options enabled
tty00 at 0x03f8 (irq = 4) is a 16450
tty01 at 0x02f8 (irq = 3) is a 16450
[...]
Floppy drive(s): fd0 is 1.2M, fd1 is 1.44M
Started kswapd v 1.4.2.2
FDC 0 is a post-1991 82077
[...]

Cheers,
-Harald