This doesn't belong in 2.0.x !!!

Arthur D. Jerijian (adj@ucla.edu)
Mon, 8 Jul 1996 07:01:17 -0700 (PDT)

Linus, Hannu, I appreciate all the effors that you're trying
to put into making Linux a high-quality kernel. But, why the h*ll
are you trying to change the sound driver so much? It was fine the
way it was in 2.0.0 before the update! In 2.0.4, I get the following
COMPILE-TIME ERROR:


make[2]: Entering directory `/home/adj/build-src/linux-2.0.4-noblink/drivers/sound'
gcc -D__KERNEL__ -I/home/adj/build-src/linux-2.0.4-noblink/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strength-reduce -pipe -m386 -DCPU=386 -c -o adlib_card.o adlib_card.c
gcc -D__KERNEL__ -I/home/adj/build-src/linux-2.0.4-noblink/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strength-reduce -pipe -m386 -DCPU=386 -c -o audio.o audio.c
gcc -D__KERNEL__ -I/home/adj/build-src/linux-2.0.4-noblink/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strength-reduce -pipe -m386 -DCPU=386 -c -o dmabuf.o dmabuf.c
gcc -D__KERNEL__ -I/home/adj/build-src/linux-2.0.4-noblink/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strength-reduce -pipe -m386 -DCPU=386 -c -o midi_synth.o midi_synth.c
gcc -D__KERNEL__ -I/home/adj/build-src/linux-2.0.4-noblink/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strength-reduce -pipe -m386 -DCPU=386 -c -o midibuf.o midibuf.c
gcc -D__KERNEL__ -I/home/adj/build-src/linux-2.0.4-noblink/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strength-reduce -pipe -m386 -DCPU=386 -c -o opl3.o opl3.c
gcc -D__KERNEL__ -I/home/adj/build-src/linux-2.0.4-noblink/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strength-reduce -pipe -m386 -DCPU=386 -c -o patmgr.o patmgr.c
gcc -D__KERNEL__ -I/home/adj/build-src/linux-2.0.4-noblink/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strength-reduce -pipe -m386 -DCPU=386 -c -o sb_card.o sb_card.c
gcc -D__KERNEL__ -I/home/adj/build-src/linux-2.0.4-noblink/include -Wall -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strength-reduce -pipe -m386 -DCPU=386 -c -o sb_common.o sb_common.c
sb_common.c: In function `probe_sbmpu':
sb_common.c:1177: parse error before `break'
make[2]: *** [sb_common.o] Error 1
make[2]: Leaving directory `/home/adj/build-src/linux-2.0.4-noblink/drivers/sound'
make[1]: *** [sub_dirs] Error 2
make[1]: Leaving directory `/home/adj/build-src/linux-2.0.4-noblink/drivers'
make: *** [linuxsubdirs] Error 2

This is all because of ONE SEMICOLON, which is fixed in the
following patch. I thought that errors like this aren't supposed to
happen in production kernels such as 2.0.x.

--- linux/drivers/sound/sb_common.c.orig Mon Jul 8 06:56:14 1996
+++ linux/drivers/sound/sb_common.c Mon Jul 8 06:56:22 1996
@@ -1173,7 +1173,7 @@
}
hw_config->name = "Sound Blaster 16";
hw_config->irq = -devc->irq;
- sb16_set_mpu_port(devc, hw_config)
+ sb16_set_mpu_port(devc, hw_config);
break;

case MDL_ESS:

--Arthur