Re: VFS Problem: close returns void
Linus Torvalds (torvalds@cs.helsinki.fi)
Fri, 6 Dec 1996 16:07:36 +0200 (EET)
On 5 Dec 1996, Derek Atkins wrote:
> alan@lxorguk.ukuu.org.uk (Alan Cox) writes:
> >
> > > POSIX compliant", I still believe that the kernel should be able to
> > > inform the user that a close failed. Filesystems that perform
> > > write-through caching wont be affected at all, but filesystems that
> > > behave like AFS will still be able to let users know when they go over
> > > quota writing a file.
> >
> > The obvious answer would be to copy the SunOS NFS response to this case.
> > Its part of a more general lack of ability to pass errors back cleanly
> > issue. Its going to attack us for NFS write behind too
>
> I'm not sure what the "SunOS NFS response" is. I'd be willing to copy
> it if I did. However, in my mind, the best solution would be to
> change the VFS close() [oops -- release()] method to return an int
> instead of returning void. Then the filesystem would have a way to
> return errors.
This _will_ be done - I'm actually expecting patches for this from Olaf
Kirch some day soon for the NFS code (needed for write-behind). He's done
all this already I'm told.
Linus