Re: ossfree version 3.8-beta4 patches, 2.1.24

Ion Badulescu (ionut@moisil.wal.rhno.columbia.edu)
Thu, 30 Jan 1997 09:54:57 -0500 (EST)


On Thu, 30 Jan 1997, Keith Owens wrote:

> diff -ur linux-2.1.24/drivers/sound/dmabuf.c linux/drivers/sound/dmabuf.c
> --- linux-2.1.24/drivers/sound/dmabuf.c Wed Jan 29 20:00:54 1997
> +++ linux/drivers/sound/dmabuf.c Thu Jan 30 21:49:28 1997
> @@ -1380,7 +1380,7 @@
> cli ();
>
> in_sleep_flag[dev].opts = WK_SLEEP;
> - select_wait (&in_sleeper[dev], wait);
> + poll_wait (&in_sleeper[dev], wait);
> restore_flags (flags);
> return 0;

[rest of the patch deleted]

Broken, broken, broken. That's not the Right Way to do it - take a look at
Linus' last message and at the 2.1.24 patch for some pointers.

Ionut

--
  It is better to keep your mouth shut and be thought a fool,
            than to open it and remove all doubt.