Re: [2.1.36] parport_procfs.c

Philip Blundell (
Wed, 7 May 1997 19:31:17 +0100 (BST)

On 7 May 1997, Matthias Urlichs wrote:

> Tim Waugh <> writes:
> > This patch is needed for 2.1.36 (on the Alpha at least).
> >
> > -#include <linux/interrupt.h>
> > #include <linux/ioport.h>
> > #include <linux/kernel.h>
> > #include <linux/malloc.h>
> > +#include <linux/interrupt.h>
> That's not the correct fix. The correct fix is to have {whatever .h file
> which needs linux/interrupt.h}.h to include that file by itself.

No, Tim's fix is the correct one. We ought to try to avoid introducing
ever more #includes between header files. It's no great hardship to
have to include things in the right order. Otherwise, you end up pulling
in frequently-used files twenty times, which doesn't do any real harm but
is a waste of time.