Re: New pre-2.0.31 patches..

Fritz Elfert (fritz@wuemaus.franken.de)
Thu, 7 Aug 1997 15:56:17 +0200 (MET DST)


On Wed, 6 Aug 1997, Paul Slootman wrote:

> There's something not very healthy with those patches. For example,
> here's a bit clipped over from another window (so excuse the lack
> of tabs etc.):
>
> diff -u --recursive --new-file v2.0.30/linux/drivers/isdn/isdn_common.c linux/dr
> ivers/isdn/isdn_common.c
> [other parts snipped]
> @@ -1694,37 +1659,40 @@
> q->next = p->next;
> else
> dev->infochain = (infostruct *) (p->next
> );
> - return;
> + kfree(p);
> + return CLOSEVAL;
> + kfree(p);

Correctly it should read:

- return;
+ return CLOSEVAL;

Don't know how Linus produced that. (All lines containing CLOSEVAL are
swapped with adjacent lines in isnd_common.c) My patches i sent to him did
it correct. Anyway, i sent another patch to him which corrects this.

Ciao
-Fritz

-- 
Fritz Elfert                                phone: +49 931 281122
Wuerzburg/Germany                           email: fritz@wuemaus.franken.de
---------------------------------------------------------------------------