Re: patch for 2.1.51 d_umount

Bill Hawes (whawes@star.net)
Tue, 19 Aug 1997 14:16:00 -0400

Linus Torvalds wrote:
> I don't like the patch - instead of having testing for the special case in
> a generic routine, I'd much have some special code in the special case.
>
> (That's a basic tenet of mine. I have hundreds of these gems. Essentially
> I hate special cases that impact generic routines - but a special case
> that can hide itself so well that it works _with_ the generic routine is
> fine).
>
> In this case, I don't see why initrd couldn't just increment the count on
> its own root inode, so that doing two dput()'s would be fine.. That way
> the normal code would stay normal.

Sounds good to me -- do_change_root should be the only case. I'll redo
the patch.

I'd still like to change "covers" to "covered" though :-)

Regards,
Bill