Re: ufs symlinks fixed
Bill Hawes (whawes@star.net)
Sun, 09 Nov 1997 18:19:05 -0500
Fare Rideau wrote:
>
> Dear Linux kernel hackers,
> before you tell me, I found why ufs symlinks worked in 2.0, but not in 2.1:
> the follow_link() code was present in the 2.0 driver, not in the 2.1 driver!!!
> Now that's fixed, and ufs seems to work as perfectly in 2.1.62 as in 2.0.31.
> (non-empty) big-endian floppy image welcome for testing. Feedback welcome.
>
> Now a question for the linux/fs/ gurus:
> how should the driver's lookup() function return an error?
> I tried to keep Adrian's original ufs xyzzy magic,
> and as long as I returned with -ENOENT, it would somehow allocate
> a resource that prevented umount()ing the partition.
> I tried to add or remove a d_add(dentry,NULL) before to return,
> without success. Which leads me to wonder what will happen
> if the part of the code that returns -EIO is reached,
> in ufs or any other driver. I admit I'm too stoopid/lazy to guess,
> but I hope an upcoming VFS documentation will enlighten me...
If you've got ufs working decently, why don't you send the completed
2.1.62 patch to Linus and get it worked into the kernel. I'll be glad
to look it over then and help track down any remaining VFS problems.
Regards,
Bill