Re: patch for 2.1.75 sunrpc/sched.c

Matti Aarnio (matti.aarnio@tele.fi)
Tue, 23 Dec 1997 01:15:51 +0200 (EET)


I am pointing at tiny bits of the code that recently got
another possible form -- smarter at Alphas, very least ;-)

> + unsigned long oldflags;
> +
> + save_flags(oldflags); cli();

Instead of this "call pair", how about:

save_and_cli(oldflags);

I happened to notice the appearance of this when I compiled
some VGER snapshot for Alpha, and it failed linkage because
somebody used this "function" ( nee, macro ).
It was trivial to write the patch, though :-)

At an alpha the amount of assembly statements is halved,
as the entire processing happens with single PALcode call.
(Tiny things try to slow the beast down, don't burden it.)

/Matti Aarnio <matti.aarnio@tele.fi>