Re: patches for menuconfig and NE2000 driver for 2.0.34

Michael Elizabeth Chastain (
Sun, 18 Jan 1998 13:44:20 -0600

Hi Trevor,

> +#ifdef CONFIG_PCI
> static int ne_probe_pci(struct device *dev);
> +#endif

This looks completely correct to me.

> - if (title && strlen(title) > atoi(argv[offset+4])-4)
> - title[atoi(argv[offset+4])-4] = 0;
> -

This looks iffy to me. But it's already in 2.1.79 and it doesn't hurt.
Leaving the code alone doesn't hurt, either, though.

In general I don't mind harmless warnings in 2.0.XX. I hate warnings
and I like to fix them, but touching code in 2.0.XX is risky.

Come on over to 2.1.XX and run 'make checkconfig' and fix some of the
dozens of <config.h> omissions and inclusions. :)

Michael Chastain
"love without fear"