Re: patch for 2.1.79 mm/filemap.c

Linus Torvalds (
Mon, 19 Jan 1998 13:49:15 -0800 (PST)

On Sun, 18 Jan 1998, Bill Hawes wrote:
> I've also added a comment about the current practice of setting
> PG_uptodate before actually copying the data into the page. I don't
> think this is right, but it will require some further analysis because
> of the complicated paths in nfs_updatepage. (And to see what other fs
> are doing in updatepage.)

Note that it should be entirely correct to mark it uptodate, BUT the page
should be marked locked until the copy has been successfully completed.
Otherwise some reader might get in while the page is still being written.