Re: Followup: copy_to_user return value breaks lots of code

Bill Hawes (
Fri, 23 Jan 1998 14:55:57 -0500

Michael Elizabeth Chastain wrote:

> Problem #2:
> A lot of code does this:
> return copy_to_user(..., ..., ...);
> This code thinks it's going to return -EFAULT, but it isnt't.

Hi Michael,

In some cases a 0 might be used as a success indication, so all of the
case #2 situations may not be errors. But if you have a list of
occurrences, why not post it so people can check it out.

I've been trying for a while to fix the places where the return from
copy_xx_user is ignored, but there are still quite a few left.