Re: Change to printk breaks /proc/kmsg

Linus Torvalds (
Fri, 23 Jan 1998 16:54:49 -0800 (PST)

On Fri, 23 Jan 1998, Bill Hawes wrote:
> The change in 2.1.80 to kernel/printk.c commenting out the wake up of
> logwait breaks /proc/kmsg for simple applications like teeing to a file.
> It seems like we would want to wake up any waiters after something new
> has been written to the log buffer. Was there some problem with doing a
> wake up at that point?


That kind of change tends to indicate that somebody has been playing
around with the low-level interrupt and/or SMP code, and wants to make
sure that a prinkt() won't lock anything up when things are badly wrong.