Re: patch to 2.1.81 to get a clean compile on i386

Andries.Brouwer@cwi.nl
Sun, 25 Jan 1998 23:06:55 +0100 (MET)


From shaw@shawc.demon.co.uk Sun Jan 25 22:01:28 1998

Re the ftape patches, don't you need something like the attached so the
changes to sigsets are protected.

+/* fix signal handling */
+
+void sigblockall( sigset_t * oldmask )
+{
+ spin_lock_irq(&current->sigmask_lock);
+ *oldmask = current->blocked;
+ sigfillset(&current->blocked);
+ recalc_sigpending(current);
+ spin_unlock_irq(&current->sigmask_lock);
+}

Possibly. I regarded this sigmask fiddling as a strange wart,
that needed some change to compile correctly. You want to
make it SMP-safe; I think I would prefer to eliminate it
altogether.
[Isnt it very strange for a device driver to worry about
signals like SIGPIPE that the calling process might get?
This may have been useful while developing the driver,
perhaps even natural if one thinks of how tar is used,
but I think it has to go again.]

Andries