Re: PNP bug

A.N.Kuznetsov (kuznet@ms2.inr.ac.ru)
Sat, 7 Feb 1998 20:09:33 +0300


In article <m0y0EPe-0005FsC@lightning.swansea.linux.org.uk> you wrote:
: - for (dev_id2 = &dev->pnp.id; dev_id2 != NULL; dev_id = dev_id2, dev_id = dev_id->next)
: + for (dev_id2 = &dev->pnp.id; dev_id2 != NULL; dev_id = dev_id2, dev_id = dev_id2->next)

Mmm... It looks like noop: dev_id == dev_id2 at this point, right?

Alan, I beg pardon I did not know that you are waiting for pnp/alpha fixes.
I append patchlet for 2.1.85 with your 2.1.85-alandiff applied.
It consists of several one-liners, making isa pnp and sound compiling
and working on AlphaPC164.

* check_irq for alpha
* include <linux/kernel.h> for alpha (apparently, on x86 it is included implicitly)
* true fix of oops in isa_isolate.c
(really, memset is overkill, dev_id->next = NULL would be enough,
but I was lazy to look at struct pnp_dev_id. Maybe, there are
another data requiring nullification there)
* oops at midi device close (I suspect true problem was not here,
but only author of this code can check it)
* oops in ess_init
* Cosmetic thing: my gcc does not compile slip.c on alpha.
Well, removing redundant verify_area makes it better not only on alpha.

Alexey Kuznetsov

begin 644 2.1.85+pnpsndalpha.dif
M9&EF9B`M=7(@;&EN=7@K86,O;&EN=7@O87)C:"]A;'!H82]K97)N96PO:7)Q
M+F,@;&EN=7@O87)C:"]A;'!H82]K97)N96PO:7)Q+F,*+2TM(&QI;G5X*V%C
M+VQI;G5X+V%R8V@O86QP:&$O:V5R;F5L+VER<2YC"49R:2!&96(@(#8@,C,Z
M,C4Z,C@@,3DY.`HK*RL@;&EN=7@O87)C:"]A;'!H82]K97)N96PO:7)Q+F,)
M4V%T($9E8B`@-R`Q.3HT,#HR.2`Q.3DX"D!`("TT,C,L-B`K-#(S+#$V($!`
M"B`C96YD:68@+RH@0T].1DE'7T%,4$A!7U-!0DQ%("HO"B!]"B`**VEN="!C
M:&5C:U]I<G$H=6YS:6=N960@:6YT(&ER<2D**WL**PES=')U8W0@:7)Q86-T
M:6]N("HJ<#L**PHK"7`@/2!I<G%?86-T:6]N("L@:7)Q.PHK"6EF("@J<"`]
M/2!.54Q,*0HK"0ER971U<FX@,#L**PER971U<FX@+45"55-9.PHK?0HK"B!I
M;G0@<F5Q=65S=%]I<G$H=6YS:6=N960@:6YT(&ER<2P@"B`)"79O:60@*"IH
M86YD;&5R*2AI;G0L('9O:60@*BP@<W1R=6-T('!T7W)E9W,@*BDL"B`)"75N
M<VEG;F5D(&QO;F<@:7)Q9FQA9W,L(`ID:69F("UU<B!L:6YU>"MA8R]L:6YU
M>"]D<FEV97)S+VYE="]S;&EP+F,@;&EN=7@O9')I=F5R<R]N970O<VQI<"YC
M"BTM+2!L:6YU>"MA8R]L:6YU>"]D<FEV97)S+VYE="]S;&EP+F,)36]N($1E
M8R`@,2`P,3HP,#HS."`Q.3DW"BLK*R!L:6YU>"]D<FEV97)S+VYE="]S;&EP
M+F,)4V%T($9E8B`@-R`Q.3HT-CHT-R`Q.3DX"D!`("TY-CDL,3$@*SDV.2PQ
M,B!`0`H@"B`)<W=I=&-H*&-M9"D@>PH@"2!C87-E(%-)3T-'249.04U%.@HM
M"0EE<G(@/2!V97)I9GE?87)E82A615))1EE?5U))5$4L(&%R9RP@<W1R;&5N
M*'-L+3YD978M/FYA;64I("L@,2D["BT)"6EF("AE<G(I("!["BT)"0ER971U
M<FX@97)R.PHM"0E]"BT)"6-O<'E?=&]?=7-E<BAA<F<L('-L+3YD978M/FYA
M;64L('-T<FQE;BAS;"T^9&5V+3YN86UE*2`K(#$I.PHK"0DO*B!0;&5A<V4L
M(&1O(&YO="!P=70@=&AI<R!L:6YE('5N9&5R(&-O<'E?=&]?=7-E<BP**PD)
M("`@:70@8G)E86MS(&UY(&]L9"!P;V]R(&=C8R!O;B!A;'!H82`M+4%.2PHK
M"0D@*B\**PD)=&UP(#T@<W1R;&5N*'-L+3YD978M/FYA;64I("L@,3L**PD)
M:68@*&-O<'E?=&]?=7-E<BAA<F<L('-L+3YD978M/FYA;64L('1M<"D@/"`P
M*0HK"0D)<F5T=7)N("U%1D%53%0["B`)"7)E='5R;B`P.PH@"B`)8V%S92!3
M24]#1TE&14Y#05`Z"F1I9F8@+75R(&QI;G5X*V%C+VQI;G5X+V1R:79E<G,O
M<&YP+VES82]I<V%?8V]N9FEG+F,@;&EN=7@O9')I=F5R<R]P;G`O:7-A+VES
M85]C;VYF:6<N8PHM+2T@;&EN=7@K86,O;&EN=7@O9')I=F5R<R]P;G`O:7-A
M+VES85]C;VYF:6<N8PE&<FD@1F5B("`V(#(S.C,T.C$T(#$Y.3@**RLK(&QI
M;G5X+V1R:79E<G,O<&YP+VES82]I<V%?8V]N9FEG+F,)4V%T($9E8B`@-R`Q
M.3HT,#HR.2`Q.3DX"D!`("TR,"PV("LR,"PW($!`"B`@*B\*(`H@(VEN8VQU
M9&4@/&QI;G5X+V-O;F9I9RYH/@HK(VEN8VQU9&4@/&QI;G5X+VME<FYE;"YH
M/@H@(VEN8VQU9&4@/&QI;G5X+W!N<"YH/@H@(VEN8VQU9&4@/&QI;G5X+W1Y
M<&5S+F@^"B`C:6YC;'5D92`\;&EN=7@O97)R;F\N:#X*9&EF9B`M=7(@;&EN
M=7@K86,O;&EN=7@O9')I=F5R<R]P;G`O:7-A+VES85]I<V]L871E+F,@;&EN
M=7@O9')I=F5R<R]P;G`O:7-A+VES85]I<V]L871E+F,*+2TM(&QI;G5X*V%C
M+VQI;G5X+V1R:79E<G,O<&YP+VES82]I<V%?:7-O;&%T92YC"49R:2!&96(@
M(#8@,C,Z,S0Z,30@,3DY.`HK*RL@;&EN=7@O9')I=F5R<R]P;G`O:7-A+VES
M85]I<V]L871E+F,)4V%T($9E8B`@-R`Q.3HT,#HR.2`Q.3DX"D!`("TV,3(L
M-B`K-C$R+#<@0$`*(`D)"7L*(`D)"0DO*B!!9&0@:70@*B\*(`D)"0ED979?
M:60@/2!D979?:60M/FYE>'0@/2!K;6%L;&]C("AS:7IE;V8@*'-T<G5C="!P
M;G!?9&5V7VED*2P@1T907TM%4DY%3"D["BL)"0D);65M<V5T*&1E=E]I9"P@
M,"P@<VEZ96]F*"ID979?:60I*3L*(`D)"0ED979?:60M/FYE>'0@/2!.54Q,
M.PH@"0D)"61E=E]I9"T^='EP92`](%!.4%](1$Q?25-!.PH@"0D)"61E=E]I
M9"T^="YI<V$N:60@/2!I9%]E<75I=E]T8FQ;:5TN:61?97%U:78["F1I9F8@
M+75R(&QI;G5X*V%C+VQI;G5X+V1R:79E<G,O<V]U;F0O;6ED:6)U9BYC(&QI
M;G5X+V1R:79E<G,O<V]U;F0O;6ED:6)U9BYC"BTM+2!L:6YU>"MA8R]L:6YU
M>"]D<FEV97)S+W-O=6YD+VUI9&EB=68N8PE-;VX@2F%N("`U(#(Q.C$R.C`R
M(#$Y.3@**RLK(&QI;G5X+V1R:79E<G,O<V]U;F0O;6ED:6)U9BYC"5-A="!&
M96(@(#<@,3DZ-#0Z,C`@,3DY.`I`0"`M-3(X+#<@*S4R."PY($!`"B!I;G0*
M($U)1$EB=69?879A:6PH:6YT(&1E=BD*('L*+0ER971U<FX@1$%405]!5D%)
M3"`H;6ED:5]I;E]B=69;9&5V72D["BL@("`@("`@(&EF("AM:61I7VEN7V)U
M9EMD979=*0HK"0ER971U<FX@1$%405]!5D%)3"`H;6ED:5]I;E]B=69;9&5V
M72D["BL)<F5T=7)N(#`["B!]"B`*(`ID:69F("UU<B!L:6YU>"MA8R]L:6YU
M>"]D<FEV97)S+W-O=6YD+W-B7V-O;6UO;BYC(&QI;G5X+V1R:79E<G,O<V]U
M;F0O<V)?8V]M;6]N+F,*+2TM(&QI;G5X*V%C+VQI;G5X+V1R:79E<G,O<V]U
M;F0O<V)?8V]M;6]N+F,)1G)I($9E8B`@-B`R,SHS-#HQ-"`Q.3DX"BLK*R!L
M:6YU>"]D<FEV97)S+W-O=6YD+W-B7V-O;6UO;BYC"5-A="!&96(@(#<@,3DZ
M-#,Z-30@,3DY.`I`0"`M-3(Q+#<@*S4R,2PX($!`"B`)9&5V8RT^;6]D96P@
M/2!-1$Q?15-3.PH@"61E=F,M/G-U8FUO9&5L(#T@97-S7VUI;F]R("8@,'@P
M9CL*(`HM"7-T<F-P>2AH=U]C;VYF:6<M/FYA;64L(&YA;64I.PHK"6EF("AH
M=U]C;VYF:6<M/FYA;64@/3T@3E5,3"D**PD):'=?8V]N9FEG+3YN86UE(#T@
M;F%M93L*(`H@"B`)<V)?9'-P7W)E<V5T*&1E=F,I.PDO*B!4=7)N(&]N(&5X
M=&5N9&5D(&UO9&4@*B\*9&EF9B`M=7(@;&EN=7@K86,O;&EN=7@O:6YC;'5D
M92]A<VTM86QP:&$O9&UA+F@@;&EN=7@O:6YC;'5D92]A<VTM86QP:&$O9&UA
M+F@*+2TM(&QI;G5X*V%C+VQI;G5X+VEN8VQU9&4O87-M+6%L<&AA+V1M82YH
M"51U92!*=6X@(#0@,#<Z,#8Z,S@@,3DY-@HK*RL@;&EN=7@O:6YC;'5D92]A
M<VTM86QP:&$O9&UA+F@)4V%T($9E8B`@-R`Q.3HT,#HR.2`Q.3DX"D!`("TS
M,3,L-B`K,S$S+#@@0$`*("\J(%1H97-E(&%R92!I;B!K97)N96PO9&UA+F,Z
M("HO"B!E>'1E<FX@:6YT(')E<75E<W1?9&UA*'5N<VEG;F5D(&EN="!D;6%N
M<BP@8V]N<W0@8VAA<B`J(&1E=FEC95]I9"D["2\J(')E<V5R=F4@82!$34$@
M8VAA;FYE;"`J+PH@97AT97)N('9O:60@9G)E95]D;6$H=6YS:6=N960@:6YT
M(&1M86YR*3L)+RH@<F5L96%S92!I="!A9V%I;B`J+PHK(V1E9FEN92!+15).
M14Q?2$%615]#2$5#2U]$34$**V5X=&5R;B!I;G0@8VAE8VM?9&UA*'5N<VEG
M;F5D(&EN="!D;6%N<BD["B`*(`H@(V5N9&EF("\J(%]!4TU?1$U!7T@@*B\*
`
end
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu