--1379539221-1170266994-888444481=:3113
Content-Type: TEXT/PLAIN; charset=US-ASCII
On Wed, 25 Feb 1998, David Woodhouse wrote:
:Date: Wed, 25 Feb 1998 18:23:53 +0000
:From: David Woodhouse <Dave@imladris.demon.co.uk>
:To: Rik van Riel <H.H.vanRiel@fys.ruu.nl>
:Cc: "Sean M. Kelly" <smkelly@zombie.org>, linux-kernel@vger.rutgers.edu
:Subject: Re: PROPOSAL: PC Speaker toggle
:
:
:H.H.vanRiel@fys.ruu.nl said:
:> OK, I've read the patch and it's so trivial that it just can't be
:> wrong.
:
:Famous last words....
:
:--- v2.1.88/drivers/char/vt.c Mon Feb 23 20:05:01 1998
:+++ linux/drivers/char/vt.c Tue Feb 24 16:42:00 1998
:@@ -33,6 +33,7 @@
:
: char vt_dont_switch = 0;
: extern struct tty_driver console_driver;
:+int spekaer_sound = 1;
: ^^^^^^^
:
[snip]:
Hmm... and that is why we shouldn't try to rewrite code to make it nicer
looking :) I also found another mistake, a missing ',' in sysctl.c.
This new attached patch has all the corrections *AND* I have successfully
compiled and tested it this time.
Thanks for pointing that out
-- Sean
-----
Sean M. Kelly
smkelly@zombie.org
--1379539221-1170266994-888444481=:3113
Content-Type: TEXT/PLAIN; charset=US-ASCII; name="patch-2.1.88+speaker"
Content-Transfer-Encoding: BASE64
Content-ID: <Pine.LNX.3.96.980225160801.3113B@main.zombie.org>
Content-Description: PC Speaker patch
ZGlmZiAtdSAtLXJlY3Vyc2l2ZSAtLW5ldy1maWxlIHYyLjEuODgvZHJpdmVy
cy9jaGFyL3Z0LmMgbGludXgvZHJpdmVycy9jaGFyL3Z0LmMNCi0tLSB2Mi4x
Ljg4L2RyaXZlcnMvY2hhci92dC5jCU1vbiBGZWIgMjMgMjA6MDU6MDEgMTk5
OA0KKysrIGxpbnV4L2RyaXZlcnMvY2hhci92dC5jCVR1ZSBGZWIgMjQgMTY6
NDI6MDAgMTk5OA0KQEAgLTMzLDYgKzMzLDcgQEANCiANCiBjaGFyIHZ0X2Rv
bnRfc3dpdGNoID0gMDsNCiBleHRlcm4gc3RydWN0IHR0eV9kcml2ZXIgY29u
c29sZV9kcml2ZXI7DQoraW50IHNwZWFrZXJfc291bmQgPSAxOw0KIA0KICNk
ZWZpbmUgVlRfSVNfSU5fVVNFKGkpCShjb25zb2xlX2RyaXZlci50YWJsZVtp
XSAmJiBjb25zb2xlX2RyaXZlci50YWJsZVtpXS0+Y291bnQpDQogI2RlZmlu
ZSBWVF9CVVNZKGkpCShWVF9JU19JTl9VU0UoaSkgfHwgaSA9PSBmZ19jb25z
b2xlIHx8IGkgPT0gc2VsX2NvbnMpDQpAQCAtMTY4LDI4ICsxNjksMzQgQEAN
CiANCiAJdW5zaWduZWQgaW50IGNvdW50ID0gMDsNCiANCi0JaWYgKGh6ID4g
MjAgJiYgaHogPCAzMjc2NykNCi0JCWNvdW50ID0gMTE5MzE4MCAvIGh6Ow0K
KwkvKiBQQyBTcGVha2VyIHRvZ2dsZSB2aWEgcHJvYyAqLw0KKwkvKiBPcmln
aW5hbGx5IGJ5IEFhcm9uIFRpZW5zaXZ1ICh0aWVuc2l2dUBwaWxvdC5tc3Uu
ZWR1KSAqLw0KKwkvKiBSZXZpc2VkIGZvciAyLjEuODggYnkgU2VhbiBLZWxs
eSA8c21rZWxseUB6b21iaWUub3JnPiAqLw0KKw0KKwlpZiAoc3BlYWtlcl9z
b3VuZCkgew0KKwkJaWYgKGh6ID4gMjAgJiYgaHogPCAzMjc2NykNCisJCQlj
b3VudCA9IDExOTMxODAgLyBoejsNCisJCQ0KKwkJY2xpKCk7DQorCQlkZWxf
dGltZXIoJnNvdW5kX3RpbWVyKTsNCisJCWlmIChjb3VudCkgew0KKwkJCS8q
IGVuYWJsZSBjb3VudGVyIDIgKi8NCisJCQlvdXRiX3AoaW5iX3AoMHg2MSl8
MywgMHg2MSk7DQorCQkJLyogc2V0IGNvbW1hbmQgZm9yIGNvdW50ZXIgMiwg
MiBieXRlIHdyaXRlICovDQorCQkJb3V0Yl9wKDB4QjYsIDB4NDMpOw0KKwkJ
CS8qIHNlbGVjdCBkZXNpcmVkIEhaICovDQorCQkJb3V0Yl9wKGNvdW50ICYg
MHhmZiwgMHg0Mik7DQorCQkJb3V0YigoY291bnQgPj4gOCkgJiAweGZmLCAw
eDQyKTsNCiAJDQotCWNsaSgpOw0KLQlkZWxfdGltZXIoJnNvdW5kX3RpbWVy
KTsNCi0JaWYgKGNvdW50KSB7DQotCQkvKiBlbmFibGUgY291bnRlciAyICov
DQotCQlvdXRiX3AoaW5iX3AoMHg2MSl8MywgMHg2MSk7DQotCQkvKiBzZXQg
Y29tbWFuZCBmb3IgY291bnRlciAyLCAyIGJ5dGUgd3JpdGUgKi8NCi0JCW91
dGJfcCgweEI2LCAweDQzKTsNCi0JCS8qIHNlbGVjdCBkZXNpcmVkIEhaICov
DQotCQlvdXRiX3AoY291bnQgJiAweGZmLCAweDQyKTsNCi0JCW91dGIoKGNv
dW50ID4+IDgpICYgMHhmZiwgMHg0Mik7DQotDQotCQlpZiAodGlja3MpIHsN
Ci0JCQlzb3VuZF90aW1lci5leHBpcmVzID0gamlmZmllcyt0aWNrczsNCi0J
CQlhZGRfdGltZXIoJnNvdW5kX3RpbWVyKTsNCi0JCX0NCi0JfSBlbHNlDQot
CQlrZF9ub3NvdW5kKDApOw0KLQlzdGkoKTsNCi1yZXR1cm47DQorCQkJaWYg
KHRpY2tzKSB7DQorCQkJCXNvdW5kX3RpbWVyLmV4cGlyZXMgPSBqaWZmaWVz
K3RpY2tzOw0KKwkJCQlhZGRfdGltZXIoJnNvdW5kX3RpbWVyKTsNCisJCQl9
DQorCQl9IGVsc2UNCisJCQlrZF9ub3NvdW5kKDApOw0KKwkJc3RpKCk7DQor
CX0NCisJcmV0dXJuOw0KIH0NCiANCiB2b2lkICgqa2RfbWtzb3VuZCkodW5z
aWduZWQgaW50IGh6LCB1bnNpZ25lZCBpbnQgdGlja3MpID0gX2tkX21rc291
bmQ7DQpkaWZmIC11IC0tcmVjdXJzaXZlIC0tbmV3LWZpbGUgdjIuMS44OC9p
bmNsdWRlL2xpbnV4L3N5c2N0bC5oIGxpbnV4L2luY2x1ZGUvbGludXgvc3lz
Y3RsLmgNCi0tLSB2Mi4xLjg4L2luY2x1ZGUvbGludXgvc3lzY3RsLmgJTW9u
IEZlYiAyMyAyMDowNTozNSAxOTk4DQorKysgbGludXgvaW5jbHVkZS9saW51
eC9zeXNjdGwuaAlUdWUgRmViIDI0IDE2OjQzOjE0IDE5OTgNCkBAIC03MCw3
ICs3MCw4IEBADQogCUtFUk5fUFJJTlRLLCAgICAgICAgICAgIC8qIHN0dXJj
dDogY29udHJvbCBwcmludGsgbG9nZ2luZyBwYXJhbWV0ZXJzICovDQogCUtF
Uk5fTkFNRVRSQU5TLAkJLyogTmFtZSB0cmFuc2xhdGlvbiAqLw0KIAlLRVJO
X1NUQVRJTk9ERSwNCi0JS0VSTl9ERU5UUlkJCS8qIGRlbnRyeSBzdGF0aXN0
aWNzICovDQorCUtFUk5fREVOVFJZLAkJLyogZGVudHJ5IHN0YXRpc3RpY3Mg
Ki8NCisJS0VSTl9QQ1NQRUFLRVIJCS8qIFBDIFNwZWFrZXIgKi8NCiB9Ow0K
IA0KIA0KZGlmZiAtdSAtLXJlY3Vyc2l2ZSAtLW5ldy1maWxlIHYyLjEuODgv
a2VybmVsL3N5c2N0bC5jIGxpbnV4L2tlcm5lbC9zeXNjdGwuYw0KLS0tIHYy
LjEuODgva2VybmVsL3N5c2N0bC5jCU1vbiBGZWIgMjMgMjA6MDY6MjYgMTk5
OA0KKysrIGxpbnV4L2tlcm5lbC9zeXNjdGwuYwlUdWUgRmViIDI0IDE2OjQ1
OjI4IDE5OTgNCkBAIC00MSw2ICs0MSw3IEBADQogZXh0ZXJuIGludCBiZGZf
cHJtW10sIGJkZmx1c2hfbWluW10sIGJkZmx1c2hfbWF4W107DQogZXh0ZXJu
IGNoYXIgYmluZm10X2phdmFfaW50ZXJwcmV0ZXJbXSwgYmluZm10X2phdmFf
YXBwbGV0dmlld2VyW107DQogZXh0ZXJuIGludCBzeXNjdGxfb3ZlcmNvbW1p
dF9tZW1vcnk7DQorZXh0ZXJuIGludCBzcGVha2VyX3NvdW5kOw0KIA0KICNp
ZmRlZiBfX3NwYXJjX18NCiBleHRlcm4gY2hhciByZWJvb3RfY29tbWFuZCBb
XTsNCkBAIC0xNTUsNiArMTU2LDggQEANCiAJe0tFUk5fU0VDVVJFTFZMLCAi
c2VjdXJlbGV2ZWwiLCAmc2VjdXJlbGV2ZWwsIHNpemVvZihpbnQpLA0KIAkg
MDQ0NCwgTlVMTCwgJnByb2NfZG9pbnR2ZWMsIChjdGxfaGFuZGxlciAqKSZk
b19zZWN1cmVsZXZlbF9zdHJhdGVneX0sDQogCXtLRVJOX1BBTklDLCAicGFu
aWMiLCAmcGFuaWNfdGltZW91dCwgc2l6ZW9mKGludCksDQorCSAwNjQ0LCBO
VUxMLCAmcHJvY19kb2ludHZlY30sDQorCXtLRVJOX1BDU1BFQUtFUiwgInNw
ZWFrZXIiLCAmc3BlYWtlcl9zb3VuZCwgc2l6ZW9mKGludCksDQogCSAwNjQ0
LCBOVUxMLCAmcHJvY19kb2ludHZlY30sDQogI2lmZGVmIENPTkZJR19CTEtf
REVWX0lOSVRSRA0KIAl7S0VSTl9SRUFMUk9PVERFViwgInJlYWwtcm9vdC1k
ZXYiLCAmcmVhbF9yb290X2Rldiwgc2l6ZW9mKGludCksDQo=
--1379539221-1170266994-888444481=:3113--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu