On Wed, 25 Feb 1998 13:16:13 +0100 (MET), Jakub Jelinek
<jj@sunsite.ms.mff.cuni.cz> said:
> The following patch adds support for large files on EXT2 on 64bit machines.
> --- ./include/linux/ext2_fs.h.jj Mon Feb 9 17:50:54 1998
> +++ ./include/linux/ext2_fs.h Wed Feb 25 09:17:03 1998
> @@ -229,7 +229,10 @@ struct ext2_inode {
> __u32 i_block[EXT2_N_BLOCKS];/* Pointers to blocks */
> __u32 i_version; /* File version (for NFS) */
> __u32 i_file_acl; /* File ACL */
> - __u32 i_dir_acl; /* Directory ACL */
> + union {
> + __u32 i_dir_acl; /* Directory ACL */
> + __u32 i_size_high; /* High 32bits of i_size for file */
> + } un1;
> __u32 i_faddr; /* Fragment address */
> union {
> struct {
I would strongly recommend that we use i_faddr instead of i_dir_acl for
this, since fragments are currently *completely* unused in all ext2fs
variants, whereas there are patches waiting to be merged which use the
acl fields.
I'm opposed to implementing fragments in ext2fs since we can get good
performance even at smaller block sizes by using the intelligent IO
clustering code, so there's no reason to go out of our way performing
the amazing hack which is ffs fragments. If we don't care about
fragments, then this field is completely open to our reuse.
--Stephen
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu