Re: Interrupts with SMP defined

Thomas Schenk (tschenk@dejanews.com)
Thu, 05 Mar 1998 10:12:00 -0600 (CST)


On 05-Mar-98 David S. Miller wrote:
> Date: Wed, 4 Mar 1998 17:03:17 -0500 (EST)
> From: Chris Loveland <cwl@fclinux-e.iol.unh.edu>
>
> spin_lock_irqsave(&some_lock, flags1);
> /* interupts now off */
> save_flags(flags2);
> cli();
> restore_flags(flags2);
> /* interupts are back on, bad stuff happens */
> spin_unlock_irqrestore(&some_lock, flags1);
>
> Don't do that.... it's just as bad (although not the same problem)
> as going:

Dave,
I believe if you read the message from Chris again, you will find
that he is not proposing that he use the code above, but that the 2.0.33
kernel already contains code that does this. Can you suggest how to
correct the problem?

Tom

---
+-----------------------+-------------------------+------------------------+
| Tom Schenk            | Use Linux!              | All opinions expressed |
| tschenk@dejanews.com  |    Friends don't let    | are mine and not those |
| tschenk@theoffice.net |     friends do Windows! | of my employer.        |
+-----------------------+-------------------------+------------------------+

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu