<grin>
Anyway, this patch fixes the following warnings in 34-pre6:
aic7xxx.c:6128: warning: unused variable `chan_num'
aic7xxx.c:6125: warning: unused variable `chip_class'
[ happens when building on an EISA or VLB box ]
dir.c:116: warning: `dump_de' defined but not used
[ the only use of dump_de in fat/dir.c is #if 0'd out ]
In addition, I forsee some problems that users may have due to the NLS
patch.
Situation 1: User applies patch-34, does make clean;make zImage but kernel
fails to link because .config has MSDOS defined but NLS is not defined
(fix: user needs to run make oldconfig after patching)
Situation 2: User with MSDOS and ISO9660 fs applies patch-34, does make
oldconfig, says N to NLS, and then make clean + zImage. User doesn't
notice that ISO9660 and MSDOS fs options silently disappeared and thus
resulting kernel doesn't get built with those fs included. (fix: user
needs to say Y to NLS, and then can say N to all the sub-NLS options)
Not sure these last two warrant any concern, but I thought it was
something worth being aware of, as it may generate some bogus bug reports.
Paul.
diff -ur linux-2034-pre6/drivers/scsi/aic7xxx.c linux/drivers/scsi/aic7xxx.c
--- linux-2034-pre6/drivers/scsi/aic7xxx.c Sun Apr 5 16:46:15 1998
+++ linux/drivers/scsi/aic7xxx.c Mon Apr 6 15:56:02 1998
@@ -6122,10 +6122,12 @@
{
int found = 0;
aha_status_type adapter_bios;
+#ifdef CONFIG_PCI
aha_chip_class_type chip_class;
+ int chan_num = 0;
+#endif
aha_chip_type chip_type;
int slot, base;
- int chan_num = 0;
unsigned char hcntrl, sxfrctl1, sblkctl, hostconf, irq = 0;
int i;
struct aic7xxx_host *p;
diff -ur linux-2034-pre6/fs/fat/dir.c linux/fs/fat/dir.c
--- linux-2034-pre6/fs/fat/dir.c Sun Apr 5 16:46:19 1998
+++ linux/fs/fat/dir.c Mon Apr 6 15:49:36 1998
@@ -112,6 +112,7 @@
}
+#if 0
static void dump_de(struct msdos_dir_entry *de)
{
int i;
@@ -123,6 +124,7 @@
}
printk("]\n");
}
+#endif
int fat_readdirx(
struct inode *inode,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu