mlord wrote:
> Attached are the current accumulated IDE bug-fixes
> against 2.1.96. If the nice folks with SMP machines
> could try these out and pass on any feedback, it would
> be greatly appreciated.
>
I don't use a SMP machine, but have some experience with ali chipset,
so my $0.02:
1. I don't think it is safe to enable other CPU's interrupts while
probing ports for chipset detection. Some of ports beeing probed
may be used by other hardware (eg. for some MB's 0x34 is same as 0x20
and probing it causes interrupt controller reprogramming)
2. Is it (possible problems during probing) the reason that chipset probing
code is not available when compiling IDE support as a module?
[...]
> diff -u --recursive --new-file --exclude=.* linux-2.1.96/drivers/block/ali14xx.c linux/drivers/block/ali14xx.c
> --- linux-2.1.96/drivers/block/ali14xx.c Mon Dec 29 12:25:29 1997
> +++ linux/drivers/block/ali14xx.c Wed Apr 15 22:17:50 1998
> @@ -154,8 +154,8 @@
> byte t;
> unsigned long flags;
>
> - save_flags(flags);
> - cli();
> + __save_flags(flags); /* local CPU only */
> + __cli(); /* local CPU only */
> for (i = 0; i < ALI_NUM_PORTS; ++i) {
> basePort = ports[i];
> regOff = inb(basePort);
[...]
> diff -u --recursive --new-file --exclude=.* linux-2.1.96/drivers/block/dtc2278.c linux/drivers/block/dtc2278.c
> --- linux-2.1.96/drivers/block/dtc2278.c Mon Dec 29 12:25:29 1997
> +++ linux/drivers/block/dtc2278.c Wed Apr 15 22:17:50 1998
> @@ -97,8 +97,8 @@
> {
> unsigned long flags;
>
> - save_flags(flags);
> - cli();
> + __save_flags(flags); /* local CPU only */
> + __cli(); /* local CPU only */
> /*
> * This enables the second interface
> */
with regards
-- ======================================================================= Andrzej M. Krzysztofowicz ankry@mif.pg.gda.pl phone: (48)(58) 347 14 61 fax: (48)(58) 347 28 21 Faculty of Applied Phys.& Maths, Technical University of Gdansk, Poland
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu