Re: Modularized x86 math emulation PATCH against pre-2.1.104-1

Michael Elizabeth Chastain (mec@shout.net)
Sun, 24 May 1998 19:19:08 -0500


Hi Adam,

In arch/i386/config.in, your patch redefines the default processor type
from Pentium to 386 -- this looks gratuitous.

I'm more concerned about the use of CONFIG_MATH_EMULATION_MODULE in
arch/i386/kernel/traps.c. I think that math_emulate_hook is fine.
But I think that it's bad to make the resident kernel be different
depending on whether or not a particular module is compiled. So I
recommend taking out these tests and compiling in math_emulate_hook
and the new code in math_emulate unconditionally.

Unfortunately there's a lot more of this stuff in your patch ...
I really hate it when the resident kernel changes depending on whether
something is a module or not included. Maybe that's just me though.

Regards,

Michael Chastain
<mailto:mec@shout.net>
"love without fear"

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu