Re: updated patch for 2.1.103 swap code

Stephen C. Tweedie (sct@dcs.ed.ac.uk)
Tue, 2 Jun 1998 23:29:51 +0100


Hi,

On Thu, 28 May 1998 07:24:20 -0400, Bill Hawes <whawes@star.net> said:

> Hi Stephen,

> I've made a small change to the previously posted patch to avoid calling
> swap_duplicate() unless there's a danger of blocking. This keeps the
> fast path free of unnecessary increments/decrements while ensuring that
> a swap entry can always be read in (barring out-of-memory errors.)

> ...

There's at least one problem with this patch: it does not call a
wait_on_page() if read_swap_cache_async() is called with wait!=0.
That may cause memory corruption if two pageins from separate
processes collide on the same page.

--Stephen

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu