Re: panic("Cyrix user");

Phil's Kernel Account (kernel@eiterra.nls.net)
Mon, 8 Jun 1998 02:00:20 -0400 (EDT)


On Sun, 7 Jun 1998, Linus Torvalds wrote:

#Nope. It's definitely not justified: the above code is just evil and
#stupid.
#I didn't even notice that part creeping in - it's not new to 2.1.105, it's
#been there for some time, and I never noticed. Whoever added that code is
#just being stupid, and I'm sorry I didn't notice (I assume that the patch
#came through David Miller - I don't tend to look through the net-specific
#patches when they come from people I tend to trust).

Heh.. okay. *puts away axe* :) Waitasec.. *grabs axe, heads towards Dave's
house* };)

#Feel free to send me a patch to fix that particular piece of braindamage.
#One option is probably to just get rid of the whole thing - I don't think
#we need the net profiling code enough to warrant this kind of stupid
#behaviour (I don' tknow who is supposed to maintain the code - nobody has
#seen fit to honour the file with a comment with a name).
#So what say you - just remove the "CONFIG_NET_PROFILE" option and the code
#associated with it?

*dig in source*

register_netdevice(&whitehole_dev);

printk("Evaluating net profiler cost ...");
#if CPU == 586 || CPU == 686
if (!(boot_cpu_data.x86_capability & 16)) {
panic("Sorry, you CPU does not support tsc. I am
dying...\n");
return -1;
}
#endif

Here's our braindead trash living in 2.1.98. Before any of the Cyrix
stuff, IIRC, which basically means this:

Whoever the hell came up with this trash unintentionally broke it on
Cyrixes. However, it's entirely their fault, and quite stupid, not to use
an alternative method, ie;

#if CPU == 586 || CPU == 686
if (!(boot_cpu_data.x86_capability & 16)) {
printk("Your CPU appears to lack a TSC.\n");
printk("Using less-accurate evaluation method.\n");
/* alternate method of some sort here */
}
#endif

I KNOW that's messy, and missing a vital part, but right now, I'm honestly
in absolutely NO shape to do more. Too many perscription drugs coursing
through my system, and Ventolin is making it's presence well known. Ugh.

Anyways, that's the clean method. Here's the dirty method.

#if CPU == 586 || CPU == 686
printk("Attempting to use Intel-style TSC.\n");
#endif

Right now, I am DESPERATELY trying to scrape up the cash for a pair of 64M
SDRAM DIMMs while they're low (BTW, those of you holding off.. prices
appear to have bottomed. Buy SOON.), as well as a *NEW* Cx6x86MX PR266+.
Total cost? ~$130 for the memory, $100 for the processor. I normally don't
beg, but if anybody would be kind enough to possibly loan me some money
(I'm only short ~$50-70), it'd REALLY help to fix this little problem. I
WOULD do it on the Cx6x86MX PR233+ I have, except for one little problem..
it's a work machine, and therefore, can't really be toyed with. ;(

And I don't think I'm making any sense at this point.. there's the ideas
so far, I'll see what more I can come up with when I'm coherent again. :)

-Phil R. Jaenke (kernel@nls.net / prj@nls.net)
TheGuyInCharge(tm), Ketyra Designs - We get paid to break stuff :)
Linux pkrea.ketyra.INT 2.0.33 #15 Sat Apr 18 00:40:21 EDT 1998 i586
Linux eiterra.nls.net 2.1.98 #15 Fri May 1 18:21:00 EDT 1998 i586
- Linus says for 'brave people only.' I say 'keep a backup.' - :)
! I reserve the right to bill spammers for my time and disk space !

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu