Re: chown() bug in fs/open.c

Alexander Kjeldaas (astor@guardian.no)
Tue, 9 Jun 1998 21:10:45 +0200


On Fri, Jun 05, 1998 at 02:34:24PM +0200, Juergen Hannappel wrote:
> Hello,
> i found a bug or at least an undocumented feature that contradicts
> the comments in the file in fs/open.c in the chown() function, both present
> in the 2.0.33 and 2.1.94 versions...
> In the section
> /*
> * If the owner has been changed, remove the setuid bit
> */

I'd say that the comment is wrong. It doesn't make sense to allow
writing to a suid file, and it is dangerous. I've checked HP-UX and
AIX - both do the same as Linux - removing suid on write.

astor

-- 
 Alexander Kjeldaas, Guardian Networks AS, Trondheim, Norway
 http://www.guardian.no/

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu