Re: patch for 2.1.103 net/ipv4/ip_fragment.c

Bill Hawes (whawes@transmeta.com)
Thu, 11 Jun 1998 08:17:32 -0700


David S. Miller wrote:

>
> As it turns out, I noticed after scanning all the code paths that we
> never get into the defragmentation code from anywhere which is not in
> a BH context. So I removed all the BH locking altogether.
>
> If you look at all the callers into that code, it is input IP packet
> processing or timers. If this were not within BH then TCP just
> wouldn't work and would crash all over the place.
>
> Therefore, since this is non-trivial to understand for people reading
> the code, I've put appropriate commentary where we used to do the BH
> locking.

Hi David,

Sounds good -- the networking code will be much easier to read and review
when we have better annotation of the locking requirements.

Hope you can get this merged into the 2.1.xx tree soon ...

Regards,
Bill

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu