Re: pre-patch-2.1.107 breaks kmod

Adam J. Richter (adam@yggdrasil.com)
Fri, 26 Jun 1998 00:30:20 -0700


> = H. Peter Anvin
>> = Adam Richter

>> [...] Is there
>> some reason why create_module() is a separate system call from
>> init_module? It seems to me that you could avoid creating these
>> locking conventions that everyone would have to think about by making
>> create_module() a no-op and making init_module() atomically do the
>> job of create_module+init_module.

>Yes, you need to reserve kernel memory in advance since the relocation
>occurs in user space (as it should.)

> -hpa

OK. I see. I can imagine complex kernel changes that
would solve the problem by changing create_module() to some sort
of generic reserve_kernel_memory() call, and delay the failure due to
name collisions until the calls to init_module(), but I think your proposal
to have insmod flock the kernel module .o file that is being loaded
is by far the simplest.

Adam J. Richter __ ______________ 4880 Stevens Creek Blvd, Suite 205
adam@yggdrasil.com \ / San Jose, California 95129-1034
+1 408 261-6630 | g g d r a s i l United States of America
fax +1 408 261-6631 "Free Software For The Rest Of Us."

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu