Re: 2.0.34: Sysctl interface, sysctl_string

Roderich Schupp (rsch@ExperTeam.de)
Mon, 10 Aug 1998 01:09:12 +0200

Frodo Looijaard <frodol@dds.nl> said:
> Concluding, I think sysctl_string should return a positive value
> instead of zero. But if I am wrong, I would be grateful if anyone
> could point out what I have overlooked.

I think you're right. sysctl_string does all the work and should
return 1, otherwise a second copy to/from user space is done
by sysctl_strategy. (Things are different for e.g. sysctl_intvec
that does only the min/max check and if this checks out leaves
the actual copying to sysctl_strategy by returning 0).
This (harmless) bug is in 2.1.115, too!

Cheers, Roderich

--
                   Klein bottle for rent -- inquire within.


Roderich Schupp                 mailto:rsch@ExperTeam.de
ExperTeam GmbH                  http://www.experteam.de/
Munich, Germany                 linux:2.1.115








-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html