Re: Simple devpts fix against 2.1.116

H. Peter Anvin (hpa@transmeta.com)
20 Aug 1998 05:06:23 GMT


Followup to: <Pine.LNX.4.02.9808192225140.12863-100000@chris.atenasio.net>
By author: Chris Atenasio <root@lilo.dyn.ml.org>
In newsgroup: linux.dev.kernel
>
>
> Does it really make sense for mounting devpts to bomb if you don't specify
> any options? I'm no devpts expert but this works for me.
>
>
> --- linux-2.1.116/fs/devpts/inode.c Wed Aug 19 19:14:55 1998
> +++ linux/fs/devpts/inode.c Wed Aug 19 22:46:56 1998
> @@ -82,7 +82,6 @@
> umode_t mode = 0600;
> char *this_char, *value;
>
> - if ( !options ) return 1;
> for (this_char = strtok(options,","); this_char; this_char =
> strtok(NULL,",")) {
> if ((value = strchr(this_char,'=')) != NULL)
> *value++ = 0;
>
>

You know... this doesn't check for no options... it checks that you
didn't pass it a null pointer...

-hpa

-- 
    PGP: 2047/2A960705 BA 03 D3 2C 14 A8 A8 BD  1E DF FE 69 EE 35 BD 74
    See http://www.zytor.com/~hpa/ for web page and full PGP public key
        I am Bahá'í -- ask me about it or see http://www.bahai.org/
   "To love another person is to see the face of God." -- Les Misérables

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html