> --- clean//Makefile Wed Aug 26 13:09:46 1998
> +++ linux/Makefile Wed Aug 26 12:55:53 1998
> @@ -265,6 +265,7 @@
> @echo \#define UTS_RELEASE \"$(VERSION).$(PATCHLEVEL).$(SUBLEVEL)\" > .ver
> @echo \#define LINUX_VERSION_CODE `expr $(VERSION) \\* 65536 + $(PATCHLEVEL) \\* 256 + $(SUBLEVEL)` >> .ver
> @echo '#define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + (c))' >>.ver
> + @echo \#define UTS_PATCHES \" `ls $(TOPDIR)/init/patches | grep -v orig` \" >> .ver
> @mv -f .ver $@
Why is the 'patches' directory located under 'init/' ??
And what if there is no 'patches' directory at all?
> --- clean//init/version.c Tue Jan 6 12:17:29 1998
> +++ linux/init/version.c Wed Aug 26 13:10:16 1998
> @@ -24,3 +24,9 @@
> const char *linux_banner =
> "Linux version " UTS_RELEASE " (" LINUX_COMPILE_BY "@"
> LINUX_COMPILE_HOST ") (" LINUX_COMPILER ") " UTS_VERSION "\n";
> +
> +const char *linux_banner_short =
> + "Linux version " UTS_RELEASE " " UTS_VERSION;
> +
> +const char *linux_banner_patches =
> + UTS_PATCHES;
Not referenced unless you have fbcon.
> --- clean//drivers/video/fbcon.c Wed Jul 29 12:51:06 1998
> +++ linux/drivers/video/fbcon.c Wed Aug 26 13:10:45 1998
Please either wait until current version of drivers/video will be
merged to the main tree or send such patches to me. Sending them directly
to Linus make my life (and especially merging of the video stuff)
very painful.
> +#define DISPLAY( x, y, text ) \
This should probably be a function.
> + msg = text; \
> + for (i=0; i<strlen(msg); i++) \
Why calculate strlen instead of just doing a loop with pointer
to current character?
> + fbcon_putc(conp, 0x0700 | msg[i], y, x+i);
Wrong. You should probably use the current color and not 0x0700 which is
probably applicable only to color displays.
> + DISPLAY( 14, 3, "Patches: " );
> + DISPLAY( 23, 3, linux_banner_patches );
Should not be displayed if there are no patches.
Have a nice fortnight
-- Martin `MJ' Mares <mj@ucw.cz> http://atrey.karlin.mff.cuni.cz/~mj/ Faculty of Math and Physics, Charles University, Prague, Czech Rep., Earth "And on the seventh day, He exited from append mode."- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html